Skip to content

Revert "[SYCL][L0] Support DPC++ extension Queue Order Properties." #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

pvchupin
Copy link
Contributor

@pvchupin pvchupin commented Apr 2, 2021

Reverts #3396 due to issues found

@pvchupin pvchupin requested review from smaslov-intel and a team as code owners April 2, 2021 18:11
@pvchupin pvchupin requested review from rbegam and kbsmith-intel April 2, 2021 18:12
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@kbsmith-intel kbsmith-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvchupin pvchupin merged commit 3160de0 into sycl Apr 2, 2021
@pvchupin pvchupin deleted the revert-3396-in-order-queue branch April 2, 2021 22:01
rbegam added a commit to rbegam/llvm that referenced this pull request Apr 3, 2021
pvchupin pushed a commit that referenced this pull request Apr 4, 2021
Return back "[SYCL][L0] Support DPC++ extension Queue Order Properties. (#3396)" reverted earlier in (#3479)
Added fix for the segfault happening due to wait on an already released event.
The related test SYCL/InorderQueue/in_order_event_release.cpp is added in llvm-test-suite.

Signed-off-by: rbegam rehana.begam@intel.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants