[NFC][SYCL] Add todo comment for validation of group-local variables definintion #3437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlychkov
force-pushed
the
private/mlychkov/private/mlychkov/kernel_local_mem_pass_todo
branch
from
654a8c7 to
f94e8b6
Compare
|
@kbobrovs Could you please review this patch? Failed test is not related to my changes and is a known issue. |
Looks like failed test was already disabled: intel/llvm-test-suite#205 |
…definintion Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
mlychkov
force-pushed
the
private/mlychkov/private/mlychkov/kernel_local_mem_pass_todo
branch
from
f94e8b6 to
fcbe5e6
Compare
|
@kbobrovs friendly ping |
kbobrovs
approved these changes
Apr 20, 2021
mlychkov
deleted the
private/mlychkov/private/mlychkov/kernel_local_mem_pass_todo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Lychkov mikhail.lychkov@intel.com