[SYCL] Cast to correct address space when a function object is passed #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premanandrao
requested review from
AGindinson,
elizabethandrews and
mdtoguchi
as code owners
smanna12
reviewed
Mar 4, 2021
smanna12
previously approved these changes
Mar 5, 2021
When a function object is passed as an argument to a call, type mismatches may be address space mismatches and these cannot be bitcast away. Check if it is an address space mismatch and if so, use the appropriate address space cast. Signed-off-by: Premanand M Rao <premanand.m.rao@intel.com>
premanandrao
force-pushed
the
remote_func_as
branch
from
1418acd to
1b89bd7
Compare
|
I had to do another force push after a rebase to fetch #3259 |
elizabethandrews
approved these changes
Mar 19, 2021
smanna12
approved these changes
Mar 19, 2021
mdtoguchi
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a function object is passed as an argument to a call,
type mismatches may be address space mismatches and these
cannot be bitcast away. Check if it is an address space
mismatch and if so, use the appropriate address space cast.
Signed-off-by: Premanand M Rao premanand.m.rao@intel.com