Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][PI][L0] Enables command batching in enqueueMemCopyHelper #3232

Merged
merged 1 commit into from
Feb 23, 2021
Merged

[SYCL][PI][L0] Enables command batching in enqueueMemCopyHelper #3232

merged 1 commit into from
Feb 23, 2021

Conversation

kbsmith-intel
Copy link
Contributor

This change enables command batching for all commands that are
enqueued using enqueueMemCopyHelper.

@kbsmith-intel
[SYCL][PI][L0] Enables command batching in enqueueMemCopyHelper
6cba757 
This change enables command batching for all commands that are
enqueued using enqueueMemCopyHelper.
smaslov-intel
smaslov-intel approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should also see if it makes any difference to additionally break the batch when the last batched command is of a different command type (copy vs. compute) such that compute doesn't "wait" for copies, and vice versa.

@bader bader merged commit 4ad9e79 into intel:sycl Feb 23, 2021
@kbsmith-intel kbsmith-intel mentioned this pull request Mar 16, 2021
Merged
bader pushed a commit that referenced this pull request Mar 17, 2021
@kbsmith-intel
[SYCL][PI][L0] Revert copy batching from #3232 (#3363)
7f5203b 
This change reverts the batching for copy commands that was done
in #3232.  That changed caused
a failure on sycl_thread_safety/event_wait test that needs further
analysis before this can be re-enabled.
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Mar 19, 2021
Merge remote-tracking branch 'upstream/sycl' into deprecate_old_apis
f1224e5 
* upstream/sycl: (1804 commits)
  [SYCL] SYCL 2020 backend interoperability part 1 (intel#3354)
  [Driver][SYCL] Address issue when unbundling for non-FPGA archive (intel#3366)
  [SYCL][Doc] Update compiler options descriptions (intel#3340)
  [SYCL] Update ABI dump tool to disable checks with libcxx by default (intel#3370)
  [SYCL] Update the way we handle -sycl-std= based on community review feedback (intel#3371)
  [SYCL] Move tests to llvm-test-suite (intel#3359)
  [SYCL][PI][L0] Revert copy batching from intel#3232 (intel#3363)
  [SYCL] Remove unsupported option.
  [SYCL] Fix pragma setting in sycl-post-link (intel#3358)
  [SYCL] Add ITT annotation instructions (intel#3299)
  [SYCL] Propagate attributes of original kernel to wrapper kernel generated for range-rounding (intel#3306)
  [BuildBot] Uplift GPU RT version for Linux to 21.09.19150 (intel#3316)
  [SYCL] Retain PI events until they have signaled (intel#3350)
  [SYCL] Add caching when using interop constructor (intel#3327)
  Add ITT stubs and wrappers for SPIR-V devices (intel#3279)
  [SYCL] Add zero argument version of buffer::reinterpret() for SYCL 2020 (intel#3333)
  [SYCL] Restore old behavior of get() method (intel#3356)
  [Driver][SYCL][FPGA] Improve FPGA AOT when using Triple (intel#3330)
  [SYCL] Revert support for pinned_host_memory extension in Level-Zero backend. Make it a NOP (intel#3349)
  [SYCL] Remove redundant build options processing (intel#3342)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaslov-intel smaslov-intel smaslov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbsmith-intel @smaslov-intel @bader