[SYCL] Add support for the SYCL_INTEL_local_memory extension to headers #3228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Header part of the implementation of group_local_memory_for_overwrite from SYCL_INTEL_local_memory extension. Declares and uses __sycl_allocate_local_memory function the calls to which will then be transformed by a function pass.
bader
reviewed
Feb 18, 2021
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
sergey-semenov
changed the title
Contributor
|
calls to which will then be transformed by a function pass. -> by a module pass. |
sergey-semenov
requested review from
a team and
dm-vodopyanov
and removed request for
a team
Contributor
Author
|
Depends on the changes from #3329 |
dm-vodopyanov
previously approved these changes
Mar 18, 2021
Contributor
Author
|
@kbobrovs ping |
kbobrovs
reviewed
Mar 23, 2021
| detail::is_group<Group>::value, | ||
| multi_ptr<T, access::address_space::local_space>> | ||
| __SYCL_ALWAYS_INLINE group_local_memory(Group g, Args &&... args) { | ||
| (void)g; |
Contributor
There was a problem hiding this comment.
NIT: descriptive macro for this - UNUSED_ARG(g) ?
Contributor
Author
There was a problem hiding this comment.
I don't mind the change, but if it is to be made, it would be more appropriate as a separate one for the whole runtime codebase, since direct casting to void is used extensively right now.
dm-vodopyanov
approved these changes
Mar 24, 2021
kbobrovs
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header part of the implementation of group_local_memory and
group_local_memory_for_overwrite from SYCL_INTEL_local_memory extension.
Declares and uses __sycl_allocate_local_memory function the calls to which
will then be transformed by a module pass.