[SYCL] Support parallel_for() accepting many reductions #3123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
Pennycook
requested changes
Feb 1, 2021
…ng c++11 (changed to c++14) Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
…reduction_N_vars_perf
Pennycook
previously approved these changes
Feb 1, 2021
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
Pennycook
previously approved these changes
Feb 2, 2021
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
|
I added a LIT test for this patch: intel/llvm-test-suite#131 An additional test-case accepting lambda-func instead of functors showed a minor issue in this implementation. |
Please add this info to commit message as requested in https://github.com/intel/llvm/blob/sycl/CONTRIBUTING.md |
vladimirlaz
previously approved these changes
Feb 2, 2021
Pennycook
previously approved these changes
Feb 3, 2021
…reduction_N_vars_perf
…:gpu) pass testing Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
v-klochkov
dismissed stale reviews from Pennycook and vladimirlaz
via
efcd7e1
…reduction_N_vars_perf
v-klochkov
added a commit
to v-klochkov/llvm-test-suite
that referenced
this pull request
Feb 4, 2021
This test verifies the following change-set in compiler: intel/llvm#3123 Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
vladimirlaz
previously approved these changes
Feb 4, 2021
Pennycook
previously approved these changes
Feb 4, 2021
romanovvlad
reviewed
Feb 4, 2021
…ode-gen at this moment. Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
…reduction_N_vars_perf
v-klochkov
dismissed stale reviews from Pennycook and vladimirlaz
via
d1fbc3b
romanovvlad
reviewed
Feb 4, 2021
romanovvlad
approved these changes
Feb 5, 2021
vladimirlaz
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Feb 8, 2021
This test verifies the following change-set in compiler: intel/llvm#3123 Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…el/llvm-test-suite#131) This test verifies the following change-set in compiler: intel#3123 Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
iclsrc
pushed a commit
that referenced
this pull request
May 12, 2025
- Implemented the TODO in the visitCallEnqueueKernel function - Takes param size and align from literal block - If dynamic allocation is used store instructions are processed to obtain size and align - Modified test Original commit: KhronosGroup/SPIRV-LLVM-Translator@ff7db6ef1c71860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LIT test testing this change-set: intel/llvm-test-suite#131
Signed-off-by: Vyacheslav N Klochkov vyacheslav.n.klochkov@intel.com