[SYCL][ESIMD] Add conversion ctor and operator #3028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kbobrovs, a test failed. However, after looking into the detail, the failure seems not relevant to esimd. What should I do in this case? |
|
@vladimirlaz, jenkins test failed. However, looking at the error details, I don't think it is related to this PR. How can we resolve this? |
|
Looks like infrastructure failure. I restarted the build. I think every PR submitter should be able to do this - click 'details' for the web page where rebuild can be started |
kbobrovs
reviewed
Jan 14, 2021
| } | ||
|
|
||
| bool test_replicate3() __attribute__((sycl_device)) { | ||
| simd<int, 8> v0(0, 1); | ||
| auto v0_rep = v0.replicate<2, 4, 2, 2>(1); | ||
|
|
||
| return v0_rep[0] == v0[1] && v0_rep[1] == v0[3] && | ||
| v0_rep[2] == v0[5]; | ||
| return v0_rep[0] == v0[1] && v0_rep[1] == v0[3] && v0_rep[2] == v0[5]; |
There was a problem hiding this comment.
please add a testcase for %=
are you going to create executable tests for new esimd functionality you add?
There was a problem hiding this comment.
test added. Yes, I will modify some existing examples to use the new esimd functionality.
There was a problem hiding this comment.
@kychendev @kbobrovs please review and merge timely
Signed-off-by: Gang Y Chen <gang.y.chen@intel.com>
cmc-rep
force-pushed
the
cmc-rep-change
branch
from
c23d5dc to
fda92f9
Compare
kychendev
approved these changes
Jan 14, 2021
kbobrovs
approved these changes
Jan 14, 2021
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jan 19, 2021
* sycl: (378 commits) [sycl-post-link][NFC] Extracted the code into a subroutine (intel#3042) [SYCL][NFC] Remove commented out code (intel#3029) [CODEOWNERS] Fix ownership of DPC++ tools tests (intel#3047) [SYCL][NFC] Make tests insensitive to dso_local (intel#3037) [SYCL] Fix acquiring a mutex in _pi_context::finalize (intel#3001) [SYCL] Fix various compilation warnings in plugins (intel#2979) [SYCL][ESIMD] Add simd class conversion ctor and operator (intel#3028) [sycl-post-link][NFC] Use range-based for loop. (intel#3033) [SYCL][NFC] Fix warning in self-build (intel#3023) [NFC] Fix sycl-post-link tests to avoid potential race (intel#3031) [SYCL][CUDA] Add missing barrier to collectives (intel#2990) [SYCL] Make Intel attributes consistent with clang attributes. (intel#3022) [SYCL] Bump SYCL minor version (intel#3026) [SYCL][Doc] Added requirement on reference to test PR in commit message (intel#3010) [SYCL] Put constant initializer list data in non-generic addr space. (intel#3005) [SYCL][L0] Fix memory leak in PiDeviceCache and ZeCommandList (intel#2974) [SYCL] Fix detection of free function calls (intel#3003) [SYCL][NFC] Clean up the builder_dir argument description (intel#3021) [SYCL][ESIMD] Fix LowerESIMD crash on a scalar fptoui LLVM instruction (intel#2699) [NFC] Remove redundant call to getMainExecutable() (intel#3018) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gang Y Chen gang.y.chen@intel.com