Skip to content

[SYCL][NFC] Employ the is_same_v helper in SYCL library #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AGindinson
Copy link
Contributor

Similarly to [b469f03], refactor the usages of the
is_same type trait to reduce code verbosity. This particular
trait was chosen because of its popularity, and will probably
be the last in this refactoring series.

Signed-off-by: Artem Gindinson artem.gindinson@intel.com

Similarly to [intel/llvm@b469f03], refactor the usages of the
`is_same` type trait to reduce code verbosity. This particular
trait was chosen because of its popularity, and will probably
be the last in this refactoring series.

Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
@AGindinson AGindinson requested review from againull, turinevgeny and a team as code owners November 16, 2020 17:51
@AGindinson
Copy link
Contributor Author

AGindinson commented Nov 16, 2020

clang-format seems to be firing a false alarm: 1 of the chunks is irrelevant to my changes. Dear reviewers, I would appreciate some advice on how to proceed here.

Artem Gindinson added 2 commits November 17, 2020 10:33
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
@AGindinson
Copy link
Contributor Author

The MSVC build failure is somewhat resembling this SO bug description.

@bader
Copy link
Contributor

bader commented Nov 17, 2020

clang-format seems to be firing a false alarm: 1 of the chunks is irrelevant to my changes. Dear reviewers, I would appreciate some advice on how to proceed here.

What clang-format version do you use locally? I think we should try using new version in CI. I think we should clang-format-9 today and it's quite old, so this issue might be already fixed in later versions.

@AGindinson
Copy link
Contributor Author

AGindinson commented Nov 17, 2020

What clang-format version do you use locally? I think we should try using new version in CI. I think we should clang-format-9 today and it's quite old, so this issue might be already fixed in later versions.

I'm basically using a self-built one, which is around version 12. How would we go about updating the one used by CI?

@bader
Copy link
Contributor

bader commented Nov 17, 2020

What clang-format version do you use locally? I think we should try using new version in CI. I think we should clang-format-9 today and it's quite old, so this issue might be already fixed in later versions.

I'm basically using a self-built one, which is around version 12. How would we go about updating the one used by CI?

I suggest using clang-format version used by CI system to avoid misalignments.

turinevgeny
turinevgeny previously approved these changes Nov 17, 2020
Copy link
Contributor

@turinevgeny turinevgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@DenisBakhvalov DenisBakhvalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the ESIMD RT library look good.

@AGindinson
Copy link
Contributor Author

Closing after the shift to C++14. Further refactoring should just use the std:: variant of type traits.

@AGindinson AGindinson closed this Feb 7, 2021
@AGindinson AGindinson deleted the private/agindins/templates-refactor branch September 22, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants