-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][NFC] Employ the is_same_v helper in SYCL library #2778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][NFC] Employ the is_same_v helper in SYCL library #2778
Conversation
Similarly to [intel/llvm@b469f03], refactor the usages of the `is_same` type trait to reduce code verbosity. This particular trait was chosen because of its popularity, and will probably be the last in this refactoring series. Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
|
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
The MSVC build failure is somewhat resembling this SO bug description. |
What |
I'm basically using a self-built one, which is around version 12. How would we go about updating the one used by CI? |
I suggest using clang-format version used by CI system to avoid misalignments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in the ESIMD RT library look good.
Closing after the shift to C++14. Further refactoring should just use the |
Similarly to [b469f03], refactor the usages of the
is_same
type trait to reduce code verbosity. This particulartrait was chosen because of its popularity, and will probably
be the last in this refactoring series.
Signed-off-by: Artem Gindinson artem.gindinson@intel.com