[SYCL][FPGA][NFC] Locally scoping the template params in pipes.hpp #2484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating fpga_lsu.hpp templates to limit parameter scope and prevent conflicts when any defines that may use B or N.
User's code could cause conflict for headers local variables, internal types. and function parameters, adding the prefix "_"
Used the locally scope GetValue as per the previous commit.
Locally scoping the template params in pipes.hpp
MrSidims
approved these changes
Sep 17, 2020
|
I synced my fork to master sycl so it's only 1 file changed now and I updated the merge conflict. Should work now! |
MrSidims
previously approved these changes
Sep 17, 2020
|
@aditikum Could you please fix regressions reported by the pre-commit testing? |
aditikum
changed the title
|
The typename was incorrectly changed resulting in the pre-commit checks failure. I've corrected it in the latest commit, this should be a NFC. |
MrSidims
approved these changes
Sep 18, 2020
romanovvlad
approved these changes
Sep 21, 2020
jsji
pushed a commit
that referenced
this pull request
Apr 18, 2024
There is no mapping to LLVM instructions, so it can be used only via SPIR-V friendly translation. This addresses p1. of #2460 Original commit: KhronosGroup/SPIRV-LLVM-Translator@8518a6f72fd586c
jsji
pushed a commit
that referenced
this pull request
Apr 18, 2024
There is no mapping to LLVM instructions, so it can be used only via SPIR-V friendly translation. This addresses p1. of #2460 Original commit: KhronosGroup/SPIRV-LLVM-Translator@8518a6f72fd586c
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
…nchinfo [DevMSAN] Move clean shadow into launch info
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[DevMSAN] Move clean shadow into launch info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the scoping of the template params in headers files.