[SYCL][Driver] Make /MD default with -fsycl for clang/clang++ drivers #2480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RT on win SYCL library is designed such a way that STL objects must cross the sycl.dll boundary, which is guaranteed to work safe on Windows only if the runtime in the app using sycl.dll and in sycl.dll is the same and is dynamic. It is not possible to implement safe approach for using sycl libraries built/linked with static C++ RT as it would cause having multiple copies of C++ objects (such as scheduler, etc), which are supposed to be singletones. This check reports a compile-time error when user tries to compile the application using sycl.dll with /MT or /MTd switches implying using static C++ runtime libcmt[d].lib. sycl.dll is built with /MD and sycld.dll is built with /MDd. Thus /MD and /MDd are allowed, and /MT /MTd switches are prohibited now.
v-klochkov
force-pushed
the
public_vklochkov_syclmtd_dll
branch
from
a817cba to
6d87519
Compare
That is odd that clang-format required me to do fixes that I did not really touch (only had changed preceding the problem places).
alexbatashev
previously approved these changes
Sep 16, 2020
No )) I did not want fixing clang-format for the rest of the file, but 'clang-format-check' buildbot required me to do that by reporting an error for the lines that I did not even touch. |
|
@mdtoguchi |
mdtoguchi
reviewed
Sep 17, 2020
|
The new static_assert in sycl/stl.hpp causes many fails in LIT tests and requires elaborate fixes in LIT tests + maybe adding back-door macro disabling the static_assert. That is why I am going to keep in only clang driver changes in this PR |
v-klochkov
changed the title
Otherwise, the errors reported during device code compilation because device code cannot handle implib call.
mdtoguchi
approved these changes
Sep 19, 2020
v-klochkov
added a commit
to v-klochkov/llvm
that referenced
this pull request
Mar 26, 2021
…t -fsycl With -fsycl switch the dynamic runtime is used. The patches (intel#2478, intel#2480, intel#2497 implemented that with -fsycl. This patch adds check that dynamic runtime is used when -fsycl is not used. That is done by a static_assert in sycl/stl.hpp. Also, lots of LIT tests had to be changed to comply with the new requirement (apps must use dynamic C++ RT with use SYCL). Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
v-klochkov
added a commit
that referenced
this pull request
Mar 31, 2021
With -fsycl switch the dynamic runtime is used. The patches (#2478, #2480, #2497 implemented that with -fsycl. Applications using sycl headers and linked with sycl[d].dll must be linked with dynamic C++ runtime on Windows even if compiled without -fsycl. This patch adds a compile time warning emitted when wrong C++ runtime is used. Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
jsji
pushed a commit
that referenced
this pull request
Apr 4, 2024
Add logic to emit only one global variable when both SPIRV builtin and OCL builtin variants are present in the source code. Signed-off-by: Arvind Sudarsanam <arvind.sudarsanam@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@2a247a49eddbc8f
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
Use UMF CUDA memory provider in UR
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Use UMF CUDA memory provider in UR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… RT on win
SYCL library is designed such a way that STL objects must cross the sycl.dll
boundary, which is guaranteed to work safe on Windows only if the runtime
in the app using sycl.dll and in sycl.dll is the same and is dynamic.
It is not possible to implement safe approach for using sycl libraries
built/linked with static C++ RT as it would cause having multiple copies
of C++ objects (such as scheduler, etc), which are supposed to be
singletones.
This check reports a compile-time error when user tries to compile
the application using sycl.dll with /MT or /MTd switches implying
using static C++ runtime libcmt[d].lib.
sycl.dll is built with /MD and sycld.dll is built with /MDd.
Thus /MD and /MDd are allowed, and /MT /MTd switches are prohibited now.