[SYCL] Reuse user ptr in buffer & fix default memory allocation #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSidims
requested changes
Jun 24, 2019
romanovvlad
previously approved these changes
Jun 24, 2019
sergey-semenov
changed the title
| @@ -21,7 +21,7 @@ class queue; | |||
| template <int dimensions> class range; | |||
|
|
|||
| template <typename T, int dimensions = 1, | |||
| typename AllocatorT = cl::sycl::buffer_allocator> | |||
| typename AllocatorT = cl::sycl::detail::aligned_allocator<T>> | |||
There was a problem hiding this comment.
align with specification
There was a problem hiding this comment.
align with specification
Spec is incorrect at this point. buffer_allocator must be a template class for various of reasons, but it's not. The issue will be created, but for now I would stay with the approach made by Sergey.
There was a problem hiding this comment.
So, what I mean, I would approve the change unless Alexey hasn't strong objections of doing so.
There was a problem hiding this comment.
No objections to approve the patch from me.
|
Resolved conflicts. |
The type is not defined by the SYCL spec. Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Treat the argument as the number of objects instead of bytes. Fix rounding up to the next multiple of alignment to avoid allocating memory for an extra object. Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Align the allocated memory in aligned_allocator by max(64, sizeof(T). Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Use the type-specific aligned_allocator<T> for buffer host memory allocation instead of the non-template buffer_allocator (which is aligned_allocator<char>). Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Reuse the pointer provided by the user in the buffer constructor (even if use_host_ptr wasn't specified) if its alignment is sufficient. Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
romanovvlad
reviewed
Jun 25, 2019
romanovvlad
reviewed
Jun 25, 2019
romanovvlad
reviewed
Jun 25, 2019
sergey-semenov
force-pushed
the
reuseptr
branch
4 times, most recently
from
64ed221 to
3625a7b
Compare
romanovvlad
approved these changes
Jun 25, 2019
MrSidims
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.