Skip to content

[SYCL] Disable loop passes in SYCL optimization mode #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bader
Copy link
Contributor

@bader bader commented Sep 2, 2020

Loop unrolling in "SYCL optimization mode" uses default heuristic, which
is tuned for CPU and might not be profitable for other devices.

@bader bader added the performance Performance related issues label Sep 2, 2020
@bader bader requested a review from AlexeySachkov September 2, 2020 18:55
@bader
Copy link
Contributor Author

bader commented Sep 2, 2020

/summary:run

@bader bader requested a review from a team as a code owner September 10, 2020 10:23
@bader bader requested a review from rbegam September 10, 2020 10:23
@bader
Copy link
Contributor Author

bader commented Sep 10, 2020

/summary:run

@bader bader changed the title [SYCL] Disable loop unrolling and vectorization [SYCL] Disable loop optimizations in SYCL optimization mode Sep 10, 2020
@bader bader changed the title [SYCL] Disable loop optimizations in SYCL optimization mode [SYCL] Disable loop passes in SYCL optimization mode Sep 10, 2020
Loop unrolling in "SYCL optimization mode" uses default heuristic, which
is tuned for CPU and might not be profitable for other devices.
This change seems to hide issues with broadcast tests on CPU.
@bader
Copy link
Contributor Author

bader commented Sep 11, 2020

/summary:run

@bader
Copy link
Contributor Author

bader commented Sep 25, 2020

Superseded by #2458.

@bader bader closed this Sep 25, 2020
@bader bader deleted the unrolling branch September 25, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant