[SYCL] Exit early while trying to enqueue blocked tasks #2347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-kanaev
reviewed
Aug 25, 2020
|
I need to fix the test failures revealed in the CI. |
Co-authored-by: sergei <57672082+s-kanaev@users.noreply.github.com>
DenisBakhvalov
force-pushed
the
private/dbakhval/enqueue-blocked-tasks
branch
from
32c51b7 to
10963c4
Compare
|
I fixed CI failures. See 2ec35d1. |
s-kanaev
reviewed
Sep 2, 2020
Comment on lines
+74
to
+80
| // We have such a graph: | ||
| // | ||
| // A | ||
| // / | \ | ||
| // B C D | ||
| // | ||
| // If C is blocked, we should not try to enqueue D. |
There was a problem hiding this comment.
Do I understand it correctly that A depends on B, C and D? Why can't we enqueue D then?
There was a problem hiding this comment.
We discussed it with @romanovvlad and AFAIU, in the current design there are no benefits of including D, as it is likely to be blocked as well.
|
@bader, please merge if no objections. |
againull
approved these changes
Sep 2, 2020
bader
pushed a commit
that referenced
this pull request
Sep 28, 2020
This patch introduces two use-cases for host-task implementation. The issue of the first use-case (`test3`) was about performance and a long-run/wait of host-taske depening on another host-task. This issue rooted in lots of enqueue calls for blocked command and was fixed in bc8f0a4 (#2347). The second use-case shows a deadlock situation when host-task `A` depends on the blocked one `B` via call `handler::depends_on()`. The `A` host-task won't be enqueued as it's `EmptyCommand` is in blocked state. The test for this use-case is disable now and will be enabled when the deadlock is fixed. The deadlock will be fixed in follow-up patch.
jsji
pushed a commit
that referenced
this pull request
Feb 15, 2024
It should have tested DebugInfoNone base type Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@e0aef72fee42e0a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.