[NFC][SYCL] Simplify the error checking of arrays by only visiting 1x. #2344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 19, 2020 07:53
Just a cleanup task I saw that should happen. None of this is really necessary to be public, so make them all private.
The current visitor requires that we go through our diagnostics checkers once per element. This is expensive, so this patch makes it an opt-out as to whether we should visit each element, or only the 1st.
erichkeane
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
|
Please forgive there being two commits, the first is covered in this review: #2345 |
|
I've now merged this with the dependent patch, so the 'diff' is now correct. |
Fznamznon
reviewed
Aug 20, 2020
keryell
reviewed
Aug 22, 2020
| for (int64_t Count = 0; Count < ElemCount; Count++) { | ||
| VisitElement(nullptr, FD, ET, handlers...); | ||
|
|
||
| assert(ElemCount > 0 && "SYCL prohibits 0 sized arrays"); |
There was a problem hiding this comment.
So, you crash the compiler when a user uses a array of size 0?
And what when not compiled with assertions?
What if this happens by meta-programming on a kernel which is not executed anyway?
There was a problem hiding this comment.
We prohibit size-zero arrays. If the user attempts to use a size-zero array in a kernel, they get a diagnostic.
jsji
pushed a commit
that referenced
this pull request
Feb 29, 2024
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
…ported [CTS] Skip images and fill2D tests if feature is not supported
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[CTS] Skip images and fill2D tests if feature is not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current visitor requires that we go through our diagnostics checkers
once per element. This is expensive, so this patch makes it an opt-out
as to whether we should visit each element, or only the 1st.