[SYCL] Add group algorithms for MUL/OR/XOR/AND operations #2339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch only adds the operations but does not fully enables them as more changes are needed in driver to conditionally or unconditionally raise the spirv std from 1.1 to 1.3, which is needed to avoid assert fails for spirv-1.3 operations being used under -spirv-max-version=1.1 used by default now. This patch also: - adds few test cases to corresponding LIT tests, which are temporarily turned off though (until CPU/GPU RT gets ready to handle the new operations). - fixes the device check in 3 LIT tests to enable them for PI_LEVEL0. Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
v-klochkov
requested review from
AlexeySachkov,
elizabethandrews,
Fznamznon,
Pennycook,
premanandrao and
a team
as code owners
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
Pennycook
previously approved these changes
Aug 18, 2020
againull
approved these changes
Aug 20, 2020
elizabethandrews
approved these changes
Aug 20, 2020
jsji
pushed a commit
that referenced
this pull request
Feb 29, 2024
…#2339) The contract between some frontends and Translator is that calls to functions which are matching to hardcoded name are converted to specific Ops in SPIR-V. The translation from LLVM to SPIR-V of OpGroupNonUnfiromShuffleDown call was done incorrectly. The struct member which is correct target for this op was left unwrapped which resulted in SPIR-V nonconforming with specification. The result of this were later problems with e.g. SPIR-V to LLVM translation. Original commit: KhronosGroup/SPIRV-LLVM-Translator@6b3ec4166a63039
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch only adds the operations but does not fully enables them
as more changes are needed in driver to conditionally or unconditionally
raise the spirv std from 1.1 to 1.3, which is needed to avoid assert
fails for spirv-1.3 operations being used under -spirv-max-version=1.1
used by default now.
This patch also:
turned off though (until CPU/GPU RT gets ready to handle the new operations).
Signed-off-by: Vyacheslav N Klochkov vyacheslav.n.klochkov@intel.com