[SYCL][Bindless Images] Add new test and re-enable bindless_images/sampling_2D_USM_host.cpp for L0 - #22960
Open
dyniols wants to merge 2 commits into
Open
[SYCL][Bindless Images] Add new test and re-enable bindless_images/sampling_2D_USM_host.cpp for L0 #22960dyniols wants to merge 2 commits into
bindless_images/sampling_2D_USM_host.cpp for L0 #22960dyniols wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds bindless-image coverage for aligned device USM and re-enables host-USM sampling on Level Zero.
Changes:
- Adds multi-format, multi-pitch 2D device-USM image testing.
- Supplies the custom row pitch through the image descriptor.
- Removes the resolved Level Zero XFAIL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
aligned_alloc_device_2d.cpp |
Tests sampled image fetches from aligned device USM. |
sampling_2D_USM_host.cpp |
Configures row pitch and enables Level Zero testing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Please review. I will take a look why tests are failing on Windows L0 specifically with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new test
sycl/test-e2e/bindless_images/aligned_alloc_device_2d.cppthat tests aligned_alloc_device withaligned row pitches ranging from the minimum supported value to 8× that value. It also re-enables
bindless_images/sampling_2D_USM_host.cppon L0 and updates its image descriptor to supply the calculated row pitch.