[SYCL] [NFC] Make instance variable in scheduler singleton #2286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
s-kanaev
commented
Aug 10, 2020
| @@ -122,14 +122,35 @@ EventImplPtr Scheduler::addCopyBack(Requirement *Req) { | |||
| // The init_priority here causes the constructor for scheduler to run relatively | |||
| // early, and therefore the destructor to run relatively late (after anything | |||
| // else that has no priority set, or has a priority higher than 2000). | |||
| Scheduler Scheduler::instance __attribute__((init_priority(2000))); | |||
| std::atomic<Scheduler *> Scheduler::instance(nullptr); | |||
There was a problem hiding this comment.
a more c++ way?
Suggested change
| std::atomic<Scheduler *> Scheduler::instance(nullptr); | |
| std::atomic<Scheduler *> Scheduler::instance{nullptr}; |
There was a problem hiding this comment.
An even more C++ way?
std::atomic<Scheduler *> Scheduler::instance {};
|
@s-kanaev isn't it going to produce a memory leak? I don't see any code for Scheduler destruction. |
|
Why not make it to be just a unique_ptr?: |
|
@s-kanaev, do you plan to merge this? |
I think not. |
vladimirlaz
added a commit
to vladimirlaz/llvm
that referenced
this pull request
Jan 12, 2022
Align installation rules for XPTI libraries with the ones used for OpenCL ICD loader to avoid installing to lib64 directory. That causes missing of the libraries during E2E testing: - llvm_test_suite_sycl/xpti_buffer* tests are impacted.
vladimirlaz
added a commit
that referenced
this pull request
Jan 13, 2022
Align installation rules for XPTI libraries with the ones used for OpenCL ICD loader to avoid installing to lib64 directory. That causes missing of the libraries during E2E testing: - llvm_test_suite_sycl/xpti_buffer* tests are impacted.
jsji
pushed a commit
that referenced
this pull request
Jan 19, 2024
This PR preserves unsigned return type of image read and unsigned texel type of image write builtins as ZeroExtend image operand in SPIRV. Original commit: KhronosGroup/SPIRV-LLVM-Translator@0aab124
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[Common] fix parseDisjointPoolConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be needed for testing purposes in unit-tests.