[SYCL] Fix thread safety issues in scheduler #2281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
|
@v-klochkov ping. |
|
/summary:run |
jsji
pushed a commit
that referenced
this pull request
Jan 4, 2024
When these passes are used in LLVM new pass manager, they can't be skipped since they are not optimization passes which are optional. Before this PR I'm seeing crash in compiler when bisecting pass manager. Original commit: KhronosGroup/SPIRV-LLVM-Translator@a682bb3
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
improve benchmark scripts and add a nightly job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes 2 issues in Scheduler::addCG() function which were found in the scope of the review #1872:
NewCmdcan be executed and removed between unique_lock and shared_lock. So it needs to be checked that NewCmd is still valid.((ExecCGCommand *)NewCmd)->flushStreams();looks not thread safe.Signed-off-by: Alexander Flegontov alexander.flegontov@intel.com