[SYCL] Add support for assuming SYCL queries fit in int #2215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdtoguchi
requested review from
AGindinson,
elizabethandrews,
Fznamznon and
premanandrao
as code owners
There was a problem hiding this comment.
@mdtoguchi should it also be enabled for https://github.com/intel/llvm/blob/sycl/sycl/test/check_device_code/id_queries_fit_int.cpp?
@alexbatashev, looks like the test can be updated to use the formal option instead of the predefine directly. I can make that adjustment. |
mdtoguchi
force-pushed
the
private/mdtoguchi/sycl-id-queries-in-int
branch
from
72560ad to
ddc0934
Compare
s-kanaev
reviewed
Jul 31, 2020
There was a problem hiding this comment.
sycl/test/basic_tests/range_offset_fit_in_int.cpp should be updated also.
|
Made updates to not have this behavior on by default. |
mdtoguchi
force-pushed
the
private/mdtoguchi/sycl-id-queries-in-int
branch
from
1741eed to
fbf863a
Compare
mdtoguchi
force-pushed
the
private/mdtoguchi/sycl-id-queries-in-int
branch
from
47fdcb2 to
0e323c7
Compare
|
@AGindinson , @premanandrao , could I get reviews? |
For good default performance, compiler needs to set -D_SYCL_ID_QUERIES_FIT_IN_INT_. This will add __builtin_assume() that says global_id/linear_id fits within MAX_INT. We also need to have an ability to override where programmer needs 31+bit in global_id/linear_id. This is provided via -f[no-]sycl-id-queries-fit-in-int
mdtoguchi
force-pushed
the
private/mdtoguchi/sycl-id-queries-in-int
branch
from
25298d9 to
fe2ab8c
Compare
alexbatashev
approved these changes
Aug 13, 2020
s-kanaev
approved these changes
Aug 13, 2020
elizabethandrews
approved these changes
Aug 13, 2020
jsji
pushed a commit
that referenced
this pull request
Nov 16, 2023
https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179 is being implemented, and some tests become obsolete. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@2075517
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For good default performance, compiler needs to set
-D_SYCL_ID_QUERIES_FIT_IN_INT_ by default. This will add
__builtin_assume() that says global_id/linear_id fits within
MAX_INT. We also need to have an ability to override where
programmer needs 31+bit in global_id/linear_id. This is
provided via -f[no-]sycl-id-queries-fit-in-int