Skip to content

[SYCL] Refactoring of queue classes #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 31, 2020

Conversation

romanovvlad
Copy link
Contributor

  1. Aligned variables names
  2. Replaced "take by value" to "take by reference" in several
    functions
  3. Reduced scope of locks
  4. Always use vector of queues instead of accessing one
    dedicated queue.

1. Aligned variables names
2. Replaced "take by value" to "take by reference" in several
   functions
3. Reduced scope of locks
4. Always use vector of queues instead of accessing one
   dedicated queue.
@romanovvlad romanovvlad requested a review from a team as a code owner July 29, 2020 14:39
@romanovvlad romanovvlad requested a review from s-kanaev July 29, 2020 14:39
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@romanovvlad
Copy link
Contributor Author

/summary:run

@romanovvlad
Copy link
Contributor Author

romanovvlad commented Jul 31, 2020

The failed test is fixed in another PR, rebasing.

@romanovvlad
Copy link
Contributor Author

/summary:run

Copy link
Contributor

@alexanderfle alexanderfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 5272332 into intel:sycl Jul 31, 2020
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
…tion

Check if compiler supports -fstack-clash-protection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants