Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildBot] Uplift OpenCL runtime versions #2148

Merged
merged 4 commits into from
Aug 3, 2020

Conversation

yinyangsx
Copy link

Signed-off-by: yinyangsx yin.yang@intel.com

@yinyangsx yinyangsx requested a review from bader as a code owner July 21, 2020 03:34
@vladimirlaz
Copy link
Contributor

Please make sure that RT is available and restart testing.Also please start full testing.

Copy link

@wanyaman wanyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ocl_gpu_rt_ver_win should be 27.20.100.8336
gpu_driver_win should be 27.20.100.8336
fpga_driver_lin should be the same as cpu_driver_lin because we are use OCLFPGA joint build in Beta08 release. The same as fpga_driver_win
please also add OCLFPGA joint build version such as: oclfpga_ver=2020.10.7.0.15 and oclfpga_ver_win=2020.10.7.0.15

OCLCPU runtime has been uploaded on SC shared folder, and waiting for Rdrive sync.
For OCLFPGA joint build, please ask Yanfeng to upload it on Rdrive firstly before restarting test.

@vladimirlaz
Copy link
Contributor

ocl_gpu_rt_ver_win should be 27.20.100.8336
gpu_driver_win should be 27.20.100.8336
fpga_driver_lin should be the same as cpu_driver_lin because we are use OCLFPGA joint build in Beta08 release. The same as fpga_driver_win
please also add OCLFPGA joint build version such as: oclfpga_ver=2020.10.7.0.15 and oclfpga_ver_win=2020.10.7.0.15

OCLCPU runtime has been uploaded on SC shared folder, and waiting for Rdrive sync.
For OCLFPGA joint build, please ask Yanfeng to upload it on Rdrive firstly before restarting test.

@yinyangsx please make sure that proper GPU Rt is installed on windows machines and proper links are provided in comment for every RT version.

@yinyangsx
Copy link
Author

ocl_gpu_rt_ver_win should be 27.20.100.8336
gpu_driver_win should be 27.20.100.8336
fpga_driver_lin should be the same as cpu_driver_lin because we are use OCLFPGA joint build in Beta08 release. The same as fpga_driver_win
please also add OCLFPGA joint build version such as: oclfpga_ver=2020.10.7.0.15 and oclfpga_ver_win=2020.10.7.0.15
OCLCPU runtime has been uploaded on SC shared folder, and waiting for Rdrive sync.
For OCLFPGA joint build, please ask Yanfeng to upload it on Rdrive firstly before restarting test.

@yinyangsx please make sure that proper GPU Rt is installed on windows machines and proper links are provided in comment for every RT version.

Windows machines have installed proper GPU RT

@yanfeng3721
Copy link
Contributor

I have update the fpga emu to rdrive, please change fpga_ver=2020.10.7.0.15
fpga_ver_win=2020.10.7.0.15.

@yinyangsx
Copy link
Author

I have update the fpga emu to rdrive, please change fpga_ver=2020.10.7.0.15
fpga_ver_win=2020.10.7.0.15.

The new FPGA RT is very different with the old in directory structure and location. Could you please provide the latest configuration solution?

@vladimirlaz
Copy link
Contributor

I have update the fpga emu to rdrive, please change fpga_ver=2020.10.7.0.15
fpga_ver_win=2020.10.7.0.15.

The new FPGA RT is very different with the old in directory structure and location. Could you please provide the latest configuration solution?

please add both variant f directories to the path

Copy link
Contributor

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update links for every modified product.
Make sure that all binaries are publicly available.
if not work with @tfzhu to make them public.

@yinyangsx yinyangsx force-pushed the deps_uplift branch 2 times, most recently from b7d196a to 99b0b92 Compare July 28, 2020 02:24
buildbot/dependency.conf Outdated Show resolved Hide resolved
@bader
Copy link
Contributor

bader commented Jul 28, 2020

@yinyangsx, please, fix CI regressions.
It looks like new driver fixes "regression/static-buffer-dtor.cpp" - please, remove XFAIL from the test.
WRT to Windows failure it seems like environment issue @tfzhu, could you take a look, please?

@yinyangsx
Copy link
Author

/summary:run

Signed-off-by: yinyangsx <yin.yang@intel.com>
@vladimirlaz
Copy link
Contributor

vladimirlaz commented Jul 31, 2020

shuffle* and common_ocl test will pass as #2219 has been submitted

hier_par_wgscope_O0.cpp can be XFAILED

@vladimirlaz
Copy link
Contributor

/summary:run

Signed-off-by: yinyangsx <yin.yang@intel.com>
@vladimirlaz
Copy link
Contributor

/summary:run

# Same GPU driver supports Level Zero and OpenCL:
# https://github.com/intel/compute-runtime/releases/tag/20.21.16886
ocl_gpu_rt_ver=20.21.16886
# https://github.com/intel/compute-runtime/releases/tag/20.25.17111
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this tag URL is different from 20.29.17408?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, sorry for thar, it should be https://github.com/intel/compute-runtime/releases/tag/20.29.17408, I will fix it in PR#2260.

Copy link
Contributor

@vladimirlaz vladimirlaz Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is bug. Should be fixed to 20.29.17408 (see #2260)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants