Skip to content

[SYCL] Handle passing O-group options via -Xarch_<arch> for JIT compilation #21129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
srividya-sundaram wants to merge 7 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] Handle passing O-group options via -Xarch_<arch> for JIT compilation #21129

srividya-sundaram wants to merge 7 commits into from

Conversation

@srividya-sundaram
Copy link
Contributor

@srividya-sundaram srividya-sundaram commented Jan 26, 2026 •
edited
Loading

This change enables passing O-group optimization options specified via -Xarch_<arch> through to SYCL JIT compilation.

Example:
clang -fsycl --offload-new-driver -Xarch_spir64 -O3 -### sycl-file.cpp

@srividya-sundaram srividya-sundaram changed the title Handle passing of O group via Xarch. [SYCL] Handle passing O-group options via -Xarch_<arch> for JIT compilation Jan 26, 2026
@srividya-sundaram srividya-sundaram marked this pull request as ready for review January 26, 2026 23:48
@srividya-sundaram srividya-sundaram requested a review from a team as a code owner January 26, 2026 23:48
mdtoguchi
mdtoguchi reviewed Jan 27, 2026
View reviewed changes
mdtoguchi
mdtoguchi reviewed Jan 27, 2026
View reviewed changes
mdtoguchi
mdtoguchi reviewed Jan 27, 2026
View reviewed changes
mdtoguchi
mdtoguchi approved these changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM!

mdtoguchi
mdtoguchi reviewed Jan 28, 2026
View reviewed changes
clang/lib/Driver/ToolChains/Clang.cpp
if (Kind == Action::OFK_SYCL) {
// Append device compiler arguments and their values to `CompilerArgs`.
for (Arg *A : BaseCompilerArgs)
A->render(BaseCompilerArgs, CompilerArgs);
Copy link
Contributor

@mdtoguchi mdtoguchi Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For efficiency, we can do this once and just fall into the Kind == Action::OFK_SYCL to add the implied args. This way there is no else from L11294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdtoguchi mdtoguchi mdtoguchi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srividya-sundaram @mdtoguchi