[L0v2] add tests dedicated for batched queue submissions #20833

EuphoricThinking · 2025-12-04T17:55:03Z

No description provided.

pbalcer

lgtm, just a few minor nits.

pbalcer · 2026-01-09T10:57:35Z

unified-runtime/test/adapters/level_zero/v2/batched_queue_test.cpp

+                                          output.data(), 0, nullptr, nullptr));
+    ASSERT_SUCCESS(urQueueFlush(queue1));
+
+    // When trying to push another submitted batch to the vector of submitted batches after reaching its arbitrarily set capacity, the vector is cleared as a result of queueFinish. Submitted batches (regular command lists) are returned to the command list cache in their destructors.


Suggested change

// When trying to push another submitted batch to the vector of submitted batches after reaching its arbitrarily set capacity, the vector is cleared as a result of queueFinish. Submitted batches (regular command lists) are returned to the command list cache in their destructors.

// When trying to push another submitted batch to the vector of submitted batches after reaching its arbitrarily set capacity, the vector is cleared as a result of queueFlush. Submitted batches (regular command lists) are returned to the command list cache in their destructors.

?

pbalcer · 2026-01-09T10:58:15Z

unified-runtime/test/adapters/level_zero/v2/batched_queue_test.cpp

+
+UUR_INSTANTIATE_DEVICE_TEST_SUITE(urBatchedQueueTest);
+
+void isEventSubmitted(ur_event_handle_t &event) {


Suggested change

void isEventSubmitted(ur_event_handle_t &event) {

void AssertEventIsSubmitted(ur_event_handle_t &event) {

pbalcer · 2026-01-09T11:19:11Z

unified-runtime/test/adapters/level_zero/v2/batched_queue_test.cpp

+
+TEST_P(urBatchedQueueTest, ReuseCommandLists) {
+  int iterNum = 3;
+  // Repetaed several times to ensure that command lists are reused when the initial capacity is reached multiple times


Suggested change

// Repetaed several times to ensure that command lists are reused when the initial capacity is reached multiple times

// Repeated several times to ensure that command lists are reused when the initial capacity is reached multiple times

pbalcer · 2026-01-09T11:19:19Z

unified-runtime/test/adapters/level_zero/v2/batched_queue_test.cpp

+  for (int i = 0; i < iterNum; i++) {
+    ASSERT_NO_FATAL_FAILURE(vectorOfSubmittedBatchesIsClearedHelper());
+  }
+}


missing newline

pbalcer · 2026-01-09T14:35:08Z

unified-runtime/test/adapters/level_zero/v2/batched_queue_test.cpp

+  ASSERT_SUCCESS(urEnqueueCommandBufferExp(queue1, cmd_buf_handle, 0, nullptr,
+                                           &eventOnImmediate));
+
+  // Operations enqueued on a regular command list must be submitted for execution before they are passed to the driver as events to wait on. Generation numbers assigned to events allow for determining whether the batch which includes an operation bound to the event has already been run: if the generation number of the event is lower than the generation number of the current batch, the batch assigned to the event has been submitted for execution. If the numbers are equal, the current batch should be submitted for execution - then, the operations enqueued on the current batch would be executed. Otherwise, the event would never be signalled. However, since command buffers are enqueued on immediate command lists, they are also submitted for execution immediately - in contrast to operations submitted on regular command lists: their execution would start only when a regular command list is enqueued directly on an immediate command list. Therefore, for events generated by submitting command buffers on batched queues, the generation number of the current batch is not tracked.


did this pass clang-format?:D please try to keep line length to 80, or max 100.

The formatter formatted the code, not the comments (make cppformat)

EuphoricThinking temporarily deployed to WindowsCILock December 4, 2025 17:55 — with GitHub Actions Inactive

EuphoricThinking temporarily deployed to WindowsCILock December 4, 2025 18:15 — with GitHub Actions Inactive

EuphoricThinking had a problem deploying to WindowsCILock December 4, 2025 18:15 — with GitHub Actions Failure

EuphoricThinking temporarily deployed to WindowsCILock December 5, 2025 18:26 — with GitHub Actions Inactive

EuphoricThinking temporarily deployed to WindowsCILock December 5, 2025 18:46 — with GitHub Actions Inactive

EuphoricThinking had a problem deploying to WindowsCILock December 5, 2025 18:46 — with GitHub Actions Failure

EuphoricThinking temporarily deployed to WindowsCILock December 5, 2025 18:46 — with GitHub Actions Inactive

EuphoricThinking force-pushed the batch_TEST1 branch from bc4d419 to d635e4f Compare December 27, 2025 09:41

EuphoricThinking had a problem deploying to WindowsCILock December 27, 2025 09:41 — with GitHub Actions Error

EuphoricThinking force-pushed the batch_TEST1 branch from d635e4f to 08e7e92 Compare December 27, 2025 09:49

EuphoricThinking temporarily deployed to WindowsCILock December 27, 2025 09:50 — with GitHub Actions Inactive

EuphoricThinking temporarily deployed to WindowsCILock December 27, 2025 10:12 — with GitHub Actions Inactive

EuphoricThinking had a problem deploying to WindowsCILock December 27, 2025 10:12 — with GitHub Actions Failure

EuphoricThinking temporarily deployed to WindowsCILock December 27, 2025 10:12 — with GitHub Actions Inactive

EuphoricThinking marked this pull request as ready for review December 28, 2025 15:38

EuphoricThinking requested a review from a team as a code owner December 28, 2025 15:38

pbalcer approved these changes Jan 9, 2026

View reviewed changes

EuphoricThinking force-pushed the batch_TEST1 branch from 08e7e92 to 7641309 Compare January 9, 2026 15:52

EuphoricThinking had a problem deploying to WindowsCILock January 9, 2026 15:52 — with GitHub Actions Error

EuphoricThinking force-pushed the batch_TEST1 branch from 7641309 to b33230f Compare January 9, 2026 16:01

EuphoricThinking temporarily deployed to WindowsCILock January 9, 2026 16:02 — with GitHub Actions Inactive

EuphoricThinking temporarily deployed to WindowsCILock January 9, 2026 16:20 — with GitHub Actions Inactive

EuphoricThinking force-pushed the batch_TEST1 branch from b33230f to efa1752 Compare January 19, 2026 17:59

EuphoricThinking temporarily deployed to WindowsCILock January 19, 2026 18:00 — with GitHub Actions Inactive

EuphoricThinking temporarily deployed to WindowsCILock January 19, 2026 18:19 — with GitHub Actions Inactive

add tests for batched queue submissions

efa1752

EuphoricThinking mentioned this pull request Jan 25, 2026

[L0v2][UR] add a limit for the number of operations in a batch #21118

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[L0v2] add tests dedicated for batched queue submissions #20833

[L0v2] add tests dedicated for batched queue submissions #20833

Uh oh!

EuphoricThinking commented Dec 4, 2025

Uh oh!

pbalcer left a comment

Uh oh!

pbalcer Jan 9, 2026

Uh oh!

pbalcer Jan 9, 2026

Uh oh!

pbalcer Jan 9, 2026

Uh oh!

pbalcer Jan 9, 2026

Uh oh!

pbalcer Jan 9, 2026

Uh oh!

EuphoricThinking Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// When trying to push another submitted batch to the vector of submitted batches after reaching its arbitrarily set capacity, the vector is cleared as a result of queueFinish. Submitted batches (regular command lists) are returned to the command list cache in their destructors.
	// When trying to push another submitted batch to the vector of submitted batches after reaching its arbitrarily set capacity, the vector is cleared as a result of queueFlush. Submitted batches (regular command lists) are returned to the command list cache in their destructors.


		UUR_INSTANTIATE_DEVICE_TEST_SUITE(urBatchedQueueTest);

		void isEventSubmitted(ur_event_handle_t &event) {

	void isEventSubmitted(ur_event_handle_t &event) {
	void AssertEventIsSubmitted(ur_event_handle_t &event) {

	// Repetaed several times to ensure that command lists are reused when the initial capacity is reached multiple times
	// Repeated several times to ensure that command lists are reused when the initial capacity is reached multiple times

[L0v2] add tests dedicated for batched queue submissions #20833

Are you sure you want to change the base?

[L0v2] add tests dedicated for batched queue submissions #20833

Uh oh!

Conversation

EuphoricThinking commented Dec 4, 2025

Uh oh!

pbalcer left a comment

Choose a reason for hiding this comment

Uh oh!

pbalcer Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

pbalcer Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

pbalcer Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

pbalcer Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

pbalcer Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

EuphoricThinking Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants