[SYCL] Disable imf libdevice for NV and AMD backend. #19190
Conversation
imf libdevice shouldn't be used by NV and AMD backend, this PR stops building it for these 2 backends. We also move all imf e2e test cases in a separate directory following exp tests. Signed-off-by: jinge90 <ge.jin@intel.com>
jinge90
requested review from
sergey-semenov and
npmiller
and removed request for
sergey-semenov
|
Hi, @npmiller |
Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
| # Add device fallback imf libraries for the NVPTX and AMD targets. | ||
| # The output files are bitcode. | ||
| foreach(arch IN LISTS devicelib_arch) |
There was a problem hiding this comment.
Could we be explicit and instead do something like:
set(imf_skip_archs "nvptx64-nvidia-cuda" "amdgcn-amd-amdhsa")
add_devicelibs(
# ...
SKIP_ARCHS ${imf_skip_archs}
)
# ...
foreach(arch IN LISTS devicelib_arch)
if (arch IN_LIST imf_skip_archs)
continue()
foreach(dtype IN ITEMS bf16 fp32 fp64)This would allow future targets that do want to use imf to just work.
There was a problem hiding this comment.
Is imf library target agnostic? If not, I suggest making it opt out by default and list the supported targets explicitly.
There was a problem hiding this comment.
Hi, @bader
The imf functions in intel/llvm repo is only a small part of all APIs and this part should be target-agnostic, the other parts from numeric team are close sourced, numeric team designed, verified and tuned only for Intel device, I am afraid these functions are not guaranteed to work correctly on NV and AMD device.
Thanks very much.
There was a problem hiding this comment.
That's what I thought, that "Intel Math Functions" were designed only "for Intel devices".
Therefore, there is no sense in building the library for any devices except Intel.
@jinge90, please, change the logic of the build script.
imf libdevice shouldn't be used by NV and AMD backend, this PR stops building it for these 2 backends.
We also move all imf e2e test cases in a separate directory following exp tests.