[NFC][SYCL] More cleanup after enable_shared_from_this for kernel_bundle_impl
#19185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bundle_impl` Follow-up for intel#18899. Also adds proper `private_tag` argument for the ctor added in intel#18949 that missed that. Also pass `span` by value while on it.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
approved these changes
Jun 27, 2025
| @@ -323,7 +323,7 @@ kernel make_kernel(const context &TargetContext, | |||
| backend Backend) { | |||
| const auto &Adapter = getAdapter(Backend); | |||
| const auto &ContextImpl = getSyclObjImpl(TargetContext); | |||
| const auto &KernelBundleImpl = getSyclObjImpl(KernelBundle); | |||
| kernel_bundle_impl &KernelBundleImpl = *getSyclObjImpl(KernelBundle); | |||
There was a problem hiding this comment.
Do we want to keep the const?
There was a problem hiding this comment.
This is a different const. Before this, it was const std::shared_ptr<T>, not std::shared_ptr<const T>.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #18899.
Also adds proper
private_tagargument for the ctor added in #18949 that missed that. Also passspanby value while on it.