[SYCL] IVDep: Add support for struct members and pointers #1908
Conversation
Struct members was missed in the initial implementation, we just need to properly handle the MemberExpr when doing our SEMA (+ consider it in a few other places). Pointers should be allowed, since the arrays decay to pointer pretty easily in the type system. The implementation is as simple as allowing it in Sema, then making sure we pass the Decl to the GEP creation function.
erichkeane
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
|
Nice one, thanks Erich! |
There isn't really. If an attribute isn't something that modifies the type, the source code itself has no way to get to the attribute. What you CAN do is make the attribute and the code both get the argument the same way, such as a single constant expression that they both reference. |
Struct members was missed in the initial implementation, we just need to
properly handle the MemberExpr when doing our SEMA (+ consider it in a
few other places).
Pointers should be allowed, since the arrays decay to pointer pretty
easily in the type system. The implementation is as simple as allowing
it in Sema, then making sure we pass the Decl to the GEP creation
function.