[SYCL] Fix use-after-free for MockHandler::getKernelName() #18801
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In current implementation, std::string is returned. For preview, caller of getKernelName() creates std::string_view from the temporary string. This sting_view is used after the temporary string is destroyed. In the fix for preview std::string_view is returned, that points to same kernel name as handler::MKernel.
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implementation, std::string is returned from getKernelName(). For preview, caller of getKernelName() creates std::string_view from the returned temporary string. This sting_view is used after the temporary string is destroyed. In the fix for preview std::string_view is returned, that points to same kernel name as handler::MKernel.