Skip to content

[CI] Force link zstd when building the compiler in CI testing #18547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025

Conversation

uditagarwal97
Copy link
Contributor

No description provided.

@uditagarwal97 uditagarwal97 self-assigned this May 19, 2025
@uditagarwal97 uditagarwal97 changed the title [CI] Build compiler with zstd [CI] Force link zstd when building the compiler in CI testing Jun 2, 2025
@uditagarwal97 uditagarwal97 requested a review from sarnex June 2, 2025 21:11
@uditagarwal97 uditagarwal97 marked this pull request as ready for review June 2, 2025 21:11
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner June 2, 2025 21:11
@uditagarwal97
Copy link
Contributor Author

@sarnex , looks like we don't have zstd installed on UR_DNP_INTEL_05_01_WinVM

@sarnex
Copy link
Contributor

sarnex commented Jun 2, 2025

Oh sorry let me fix it now

@sarnex
Copy link
Contributor

sarnex commented Jun 3, 2025

I fixed 2/3 of the build runners but the KVM is down on the last one, making a ticket to fix it.

@sarnex
Copy link
Contributor

sarnex commented Jun 3, 2025

@uditagarwal97 I fixed the last runner but it seems like the Jenkins build uses --ci-defaults and that's failing now, so not sure what we can do. Maybe just add it manually in the workflow?

@uditagarwal97
Copy link
Contributor Author

@uditagarwal97 I fixed the last runner but it seems like the Jenkins build uses --ci-defaults and that's failing now, so not sure what we can do. Maybe just add it manually in the workflow?

Ahh.. I see. Yes, I guess we can add it to the workflow directly. Will update the PR.

Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for now but can we open a ticket internally to install zstd on the jenkins build systems so we can go back to the configure.py change?

@uditagarwal97
Copy link
Contributor Author

lgtm for now but can we open a ticket internally to install zstd on the jenkins build systems so we can go back to the configure.py change?

Sure, I've created an internal ticket.

@sarnex
Copy link
Contributor

sarnex commented Jun 6, 2025

Thanks!

@uditagarwal97 uditagarwal97 merged commit d51f90e into sycl Jun 6, 2025
33 checks passed
@uditagarwal97 uditagarwal97 deleted the zstd_ci_build branch June 6, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants