[SYCL][CUDA] LIT SPIR-V test unsupported

[bjoernknafla]

Mark a LIT test that checks for SPIR-V specific trace output as
unsupported by CUDA as the CUDA plugin does not support SPIR-V.

Signed-off-by: Bjoern Knafla bjoern@codeplay.com

[againull]

Does it make sense to save this scheduler test for CUDA by replacing this check by the check below?
// CHECK:---> pi{{[a-zA-Z_]*}}ProgramCreate{{[a-zA-Z_]*}}

[bjoernknafla]

@againull That is a great idea! I will look into that.

[bader]

@againull, what PI function we use to create a program in AOT mode with level0?

[againull]

@againull, what PI function we use to create a program in AOT mode with level0?

piclProgramCreateWithBinary if i am not mistaken.

[bader]

@againull, what PI function we use to create a program in AOT mode with level0?

piclProgramCreateWithBinary if i am not mistaken.

So, all backends including CUDA and level0 implement picl* function, which seems to be OpenCL specific.
Shoudn't we extend piCreateProgram with "Binary" format support in addition to SPIR-V?
Or remove the cl from the pi function name?

[smaslov-intel]

Or remove the cl from the pi function name?

+1

Level-Zero supports piclProgramCreateWithBinary is is no longer OpenCL only (unlike piclProgramCreateWithSource)

[bjoernknafla]

I am not sure if I have testing of Level0 locally set up - if I change the PI function naming will the buildbots find if I missed something in Level0?

There are also tests with symbol dumps in them - not sure yet how they are created (seems that only the test file itself needs to be edited). As I have more pressing issues on my stack and the renaming might take more investigation than expected this PR might have to wait a bit.

[bader]

I'm fine with doing renaming in a separate PR.

[bjoernknafla]

I will close this PR then.

[bader]

I will close this PR then.

I thought you are going to enable this test for CUDA following the suggestion from @againull

Does it make sense to save this scheduler test for CUDA by replacing this check by the check below?
// CHECK:---> pi{{[a-zA-Z_]*}}ProgramCreate{{[a-zA-Z_]*}}

[bjoernknafla]

I will close this and then open a PR with the piclProgramCreateWithBinary to piProgramCreateWithBinary rename that should also enable this test for CUDA.

[bjoernknafla]

Closing in favor for #1865