Skip to content

[UR] Move adapter tests over to lit #18397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

[UR] Move adapter tests over to lit #18397

merged 1 commit into from
May 29, 2025

Conversation

RossBrunton
Copy link
Contributor

This moves the CUDA/HIP and Level Zero adapter tests over to
lit. New targets are available, check-unified-runtime-level_zero,
check-unified-runtime-hip and check-unified-runtime-cuda where
applicable. The generic check-unified-runtime-adapter can be
used to run it all the above.

@RossBrunton RossBrunton requested a review from steffenlarsen May 27, 2025 09:50
@RossBrunton
Copy link
Contributor Author

https://github.com/intel/llvm/actions/runs/15252687628/job/42893633907 Example of an (artificial) failure from this patch.

steffenlarsen
steffenlarsen reviewed May 27, 2025
View reviewed changes
unified-runtime/test/CMakeLists.txt
@@ -26,6 +26,8 @@ set(INSTALL_GTEST OFF)
FetchContent_MakeAvailable(googletest)
enable_testing()

find_program(VALGRIND valgrind)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have just been moved from unified-runtime/test/adapters/CMakeLists.txt, but what do we need valgrind for? Is it to propagate it in the lit configuration further down?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, it's so the .in file can be populated with the path to the valgrind binary. In theory I could add a .in file in test/adapters, but that feels like more effort than it's worth.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, but a comment might be good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment.

steffenlarsen
steffenlarsen approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small open, but otherwise LGTM!

@RossBrunton
[UR] Move adapter tests over to lit
9d40aff 
This moves the CUDA/HIP and Level Zero adapter tests over to
lit. New targets are available, `check-unified-runtime-level_zero`,
`check-unified-runtime-hip` and `check-unified-runtime-cuda` where
applicable. The generic `check-unified-runtime-adapter` can be
used to run it all the above.
@RossBrunton
Copy link
Contributor Author

@pbalcer Just noticed that the ctest invocation has -E "memcheck" which excludes one of the tests since it seems to be timing out on CI. I've just added this exclusion to the LIT_OPTS. Are you still okay with this MR given that new change?

@pbalcer
Copy link
Contributor

pbalcer commented May 28, 2025

@pbalcer Just noticed that the ctest invocation has -E "memcheck" which excludes one of the tests since it seems to be timing out on CI. I've just added this exclusion to the LIT_OPTS. Are you still okay with this MR given that new change?

Yes, the memcheck issue shouldn't block this patch from proceeding. If I had to guess this is an issue this particular version of memcheck in CI is not working well with the particular version of the driver in CI.
Let's just keep it disabled.

Thanks for asking!

@RossBrunton
Copy link
Contributor Author

@intel/llvm-gatekeepers Please merge.

@kbenzie kbenzie merged commit 588243f into sycl May 29, 2025
41 of 45 checks passed
@kbenzie kbenzie deleted the ross/evenmorelit branch May 29, 2025 09:26
RossBrunton added a commit to RossBrunton/intel-llvm that referenced this pull request Jun 3, 2025
@RossBrunton
[UR][CI] Disable other timeouting test
d24a20c 
Change intel#18397 switches a filter for "memcheck" to an explicit path.
However, that filter would have also hit
deferred_kernel_memcheck.test. Since that test is also timing out
randomly, disable it too.
@RossBrunton RossBrunton mentioned this pull request Jun 3, 2025
Merged
sarnex pushed a commit that referenced this pull request Jun 3, 2025
@RossBrunton
[UR][CI] Disable other timeouting test (#18780)
2b94edd 
Change #18397 switches a filter for "memcheck" to an explicit path.
However, that filter would have also hit
deferred_kernel_memcheck.test. Since that test is also timing out
randomly, disable it too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbalcer pbalcer pbalcer approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RossBrunton @pbalcer @steffenlarsen @kbenzie