Skip to content

[SYCL][UR][L0 v2] Use discrete buffer implementation for integrated GPUs #18354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

[SYCL][UR][L0 v2] Use discrete buffer implementation for integrated GPUs #18354

merged 1 commit into from
May 12, 2025

Conversation

igchor
Copy link
Member

@igchor igchor commented May 7, 2025 •
edited
Loading

No description provided.

@igchor igchor temporarily deployed to WindowsCILock May 7, 2025 18:25 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 7, 2025 18:47 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 7, 2025 18:47 — with GitHub Actions Inactive
@igchor igchor force-pushed the tmp_use_discrete_buffer_on_integrated branch from bd5cec6 to 617abfd Compare May 7, 2025 19:09
@igchor igchor temporarily deployed to WindowsCILock May 7, 2025 19:09 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 7, 2025 19:31 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 7, 2025 19:31 — with GitHub Actions Inactive
@igchor igchor force-pushed the tmp_use_discrete_buffer_on_integrated branch from 617abfd to 9f68cd2 Compare May 7, 2025 20:14
@igchor igchor temporarily deployed to WindowsCILock May 7, 2025 20:14 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 7, 2025 20:57 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 7, 2025 20:57 — with GitHub Actions Inactive
@igchor igchor force-pushed the tmp_use_discrete_buffer_on_integrated branch from 9f68cd2 to 615257c Compare May 8, 2025 16:22
@igchor igchor temporarily deployed to WindowsCILock May 8, 2025 16:22 — with GitHub Actions Inactive
@igchor igchor changed the title [SYCL][UR][L0 v2] Use discrete buffer implementation for integrated GPUs [SYCL][UR][L0 v2] Enable v2 testing on GEN12, PVC and BMG May 8, 2025
@igchor igchor temporarily deployed to WindowsCILock May 8, 2025 17:39 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 8, 2025 17:39 — with GitHub Actions Inactive
@igchor igchor force-pushed the tmp_use_discrete_buffer_on_integrated branch from 615257c to d428516 Compare May 8, 2025 18:41
@igchor igchor temporarily deployed to WindowsCILock May 8, 2025 18:41 — with GitHub Actions Inactive
@igchor igchor changed the title [SYCL][UR][L0 v2] Enable v2 testing on GEN12, PVC and BMG [SYCL][UR][L0 v2] Use discrete buffer implementation for integrated GPUs May 8, 2025
@igchor igchor marked this pull request as ready for review May 8, 2025 18:42
@igchor igchor requested a review from a team as a code owner May 8, 2025 18:42
@igchor igchor temporarily deployed to WindowsCILock May 8, 2025 19:30 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 8, 2025 19:30 — with GitHub Actions Inactive
@pbalcer
Copy link
Contributor

pbalcer commented May 12, 2025

I restarted CI twice, [SYCL Pre Commit on Linux / run_prebuilt_e2e_tests (Intel Arc A-Series Graphics, ["Linux", "arc"]] this just doesn't want to run. Can you please rebase your PR?

@igchor igchor force-pushed the tmp_use_discrete_buffer_on_integrated branch from d428516 to 892cbab Compare May 12, 2025 16:30
@igchor igchor temporarily deployed to WindowsCILock May 12, 2025 16:30 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 12, 2025 17:12 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 12, 2025 17:12 — with GitHub Actions Inactive
@igchor
[SYCL][UR][L0 v2] the ur_integrated_buffer_handle_t
892cbab 
does not follow SYCL expectations. For now, use
discrete_buffer which works fine.
@igchor
Copy link
Member Author

igchor commented May 12, 2025

@intel/llvm-gatekeepers this is ready for merge - failures are unrelated: #18416

@aelovikov-intel aelovikov-intel merged commit f1d4cd7 into intel:sycl May 12, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbalcer pbalcer pbalcer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igchor @pbalcer @aelovikov-intel