Skip to content

[SYCL] Eliminate XPTI overhead when it is disabled #18334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

vinser52
Copy link
Contributor

@vinser52 vinser52 commented May 6, 2025

Even if the XPTI collector is not used, we still have some overhead related to XPTI instrumentation when we call xptiRegisterStream function.

With these changes, we cache the result of the xptiTraceEnabled function in the static variables. It is safe to cache it because XPTI collector is enabled by the XPTI_FRAMEWORK_DISPATCHER environment variable before the process starts.

VTune shows ~2% decrease in the number of instructions retired on a submit kernel path.

@vinser52 vinser52 requested a review from a team as a code owner May 6, 2025 13:20
@vinser52 vinser52 requested a review from sergey-semenov May 6, 2025 13:20
@vinser52 vinser52 requested a review from a team as a code owner May 6, 2025 13:29
@vinser52 vinser52 requested a review from Bensuo May 6, 2025 13:29
@vinser52 vinser52 temporarily deployed to WindowsCILock May 6, 2025 13:29 — with GitHub Actions Inactive
@vinser52 vinser52 temporarily deployed to WindowsCILock May 6, 2025 14:12 — with GitHub Actions Inactive
@vinser52 vinser52 temporarily deployed to WindowsCILock May 6, 2025 14:12 — with GitHub Actions Inactive
@pbalcer
Copy link
Contributor

pbalcer commented May 6, 2025

@jfedorov @mschilling0 fyi

Copy link
Contributor

@Bensuo Bensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graph-related changes LGTM.

Signed-off-by: Sergei Vinogradov <sergey.vinogradov@intel.com>
Signed-off-by: Sergei Vinogradov <sergey.vinogradov@intel.com>
@vinser52 vinser52 temporarily deployed to WindowsCILock May 7, 2025 17:26 — with GitHub Actions Inactive
@vinser52 vinser52 temporarily deployed to WindowsCILock May 7, 2025 17:48 — with GitHub Actions Inactive
@vinser52 vinser52 temporarily deployed to WindowsCILock May 7, 2025 17:48 — with GitHub Actions Inactive
@vinser52
Copy link
Contributor Author

vinser52 commented May 7, 2025

@intel/llvm-gatekeepers PR is ready to be merged. CI failure is unrelated to this PR, see #17486

@sarnex sarnex merged commit b7093bf into intel:sycl May 7, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants