Skip to content

[Joint Matrix] Enable different accumulator and output types in spirv. Add tests to cover bfloat16 and half floating-point sizes. #17502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[Joint Matrix] Enable different accumulator and output types in spirv. Add tests to cover bfloat16 and half floating-point sizes. #17502

wants to merge 1 commit into from

Conversation

ggojska
Copy link
Contributor

@ggojska ggojska commented Mar 18, 2025

Updated matrix_compare and matrix_multiply_ref functions to better match bfloat16 calculations on device.

@ggojska ggojska requested a review from a team as a code owner March 18, 2025 12:28
@ggojska ggojska self-assigned this Mar 18, 2025
@ggojska ggojska requested review from YuriPlyakhin and dkhaldi March 18, 2025 12:28
@ggojska ggojska marked this pull request as draft March 18, 2025 13:08
dkhaldi
dkhaldi reviewed Mar 18, 2025
View reviewed changes
@ggojska ggojska force-pushed the commonhpp_reference_calculation_change branch from f5e46ba to 3a5de5a Compare March 18, 2025 14:45
YuriPlyakhin
YuriPlyakhin reviewed Mar 18, 2025
View reviewed changes
YuriPlyakhin
YuriPlyakhin reviewed Mar 18, 2025
View reviewed changes
@ggojska ggojska force-pushed the commonhpp_reference_calculation_change branch from 3a5de5a to c5be2c5 Compare March 21, 2025 13:53
dkhaldi
dkhaldi requested changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to change the test to separate acccumulator from desctination. There are 4 cases:
acc bf16, dest float
acc bf16, dest bf16
acc float, dest float
acc float, dest bf16

@ggojska ggojska force-pushed the commonhpp_reference_calculation_change branch from c5be2c5 to 29c35ac Compare March 24, 2025 14:15
@ggojska ggojska force-pushed the commonhpp_reference_calculation_change branch from 29c35ac to 8116625 Compare March 24, 2025 15:01
@ggojska ggojska force-pushed the commonhpp_reference_calculation_change branch from 8116625 to fc7eaf7 Compare March 25, 2025 13:17
YuriPlyakhin
YuriPlyakhin reviewed Jun 2, 2025
View reviewed changes
YuriPlyakhin
YuriPlyakhin reviewed Jun 3, 2025
View reviewed changes
YuriPlyakhin
YuriPlyakhin reviewed Jun 3, 2025
View reviewed changes
YuriPlyakhin
YuriPlyakhin reviewed Jun 3, 2025
View reviewed changes
YuriPlyakhin
YuriPlyakhin reviewed Jun 3, 2025
View reviewed changes
sycl/test-e2e/Matrix/joint_matrix_bfloat16_PackedB.cpp Outdated
// UNSUPPORTED: target-nvidia, target-amd
// UNSUPPORTED-INTENDED: aspect-ext_intel_matrix isn't currently supported for
// other triples

// REQUIRES: aspect-ext_intel_matrix
// REQUIRES-INTEL-DRIVER: lin: 27868, win: 101.5181
// REQUIRES-INTEL-DRIVER: lin: 27501, win: 101.4943
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this change?

YuriPlyakhin
YuriPlyakhin reviewed Jun 3, 2025
View reviewed changes
sycl/test-e2e/Matrix/joint_matrix_bfloat16_PackedB_Accumulator.cpp Outdated
// other triples

// REQUIRES: aspect-ext_intel_matrix
// REQUIRES-INTEL-DRIVER: lin: 27501, win: 101.4943
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this version of driver required?

YuriPlyakhin
YuriPlyakhin reviewed Jun 3, 2025
View reviewed changes
YuriPlyakhin
YuriPlyakhin reviewed Jun 3, 2025
View reviewed changes
YuriPlyakhin
YuriPlyakhin reviewed Jun 3, 2025
View reviewed changes
YuriPlyakhin
YuriPlyakhin reviewed Jun 3, 2025
View reviewed changes
YuriPlyakhin
YuriPlyakhin requested changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provided review.

@ggojska ggojska force-pushed the commonhpp_reference_calculation_change branch from 5279c10 to 1bdb402 Compare June 6, 2025 11:37
@ggojska ggojska temporarily deployed to WindowsCILock June 6, 2025 12:04 — with GitHub Actions Inactive
@ggojska ggojska temporarily deployed to WindowsCILock June 6, 2025 12:04 — with GitHub Actions Inactive
@ggojska ggojska force-pushed the commonhpp_reference_calculation_change branch from 1bdb402 to febd44d Compare June 6, 2025 13:59
@ggojska ggojska force-pushed the commonhpp_reference_calculation_change branch from febd44d to 460ea6e Compare June 6, 2025 14:03
@ggojska ggojska temporarily deployed to WindowsCILock June 6, 2025 14:04 — with GitHub Actions Inactive
@ggojska ggojska force-pushed the commonhpp_reference_calculation_change branch from 460ea6e to 918c453 Compare June 6, 2025 14:33
@ggojska ggojska temporarily deployed to WindowsCILock June 6, 2025 14:34 — with GitHub Actions Inactive
@ggojska ggojska temporarily deployed to WindowsCILock June 6, 2025 15:00 — with GitHub Actions Inactive
@ggojska ggojska temporarily deployed to WindowsCILock June 6, 2025 15:00 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriPlyakhin YuriPlyakhin YuriPlyakhin requested changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-runtime

@dkhaldi dkhaldi Awaiting requested review from dkhaldi

Requested changes must be addressed to merge this pull request.

Assignees

@ggojska ggojska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggojska @YuriPlyakhin @dkhaldi