Skip to content

[SYCL] vec convert of long long types correction. #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 22, 2020
Merged

[SYCL] vec convert of long long types correction. #1734

merged 6 commits into from
May 22, 2020

Conversation

fadeeval
Copy link
Contributor

Fix regression from PR #1576

Signed-off-by: Aleksander Fadeev aleksander.fadeev@intel.com

fadeeval added 4 commits May 19, 2020 19:31
@fadeeval
tepes.cpp fix
c99ef67 
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
@fadeeval
tepes.cpp fix 2
a406e93 
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
@fadeeval
types.hpp fix3
55a62ad 
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
@fadeeval
Formatting
39928ce 
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
@fadeeval fadeeval requested a review from turinevgeny as a code owner May 21, 2020 08:31
@fadeeval fadeeval requested review from AlexeySachkov and bader May 21, 2020 08:32
@fadeeval
Formatting
943338d 
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
@fadeeval
Copy link
Contributor Author

@turinevgeny, make review, please

turinevgeny
turinevgeny reviewed May 21, 2020
View reviewed changes
Copy link
Contributor

@turinevgeny turinevgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a LIT test?

@fadeeval
Copy link
Contributor Author

fadeeval commented May 21, 2020 •
edited
Loading

Would it make sense to add a LIT test?

I think that changes in vec_convert_i_to_i.cpp may be useful, so if no objection I will do it

@turinevgeny
Copy link
Contributor

Would it make sense to add a LIT test?

I think that changes in vec_convert_i_to_i.cpp may be useful, so if no objection I will do it

Ok.

@fadeeval
vec_convert_i_to_i.cpp addition
7849526 
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
@fadeeval fadeeval requested a review from a team as a code owner May 21, 2020 14:45
@fadeeval fadeeval requested a review from sergey-semenov May 21, 2020 14:45
turinevgeny
turinevgeny approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@turinevgeny turinevgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

sergey-semenov
sergey-semenov approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@sergey-semenov sergey-semenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 76eab93 into intel:sycl May 22, 2020
@fadeeval fadeeval deleted the private/fadeeval/Some_CTS_vector_test_compfail branch June 1, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turinevgeny turinevgeny turinevgeny approved these changes

@sergey-semenov sergey-semenov sergey-semenov approved these changes

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

@bader bader Awaiting requested review from bader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fadeeval @turinevgeny @sergey-semenov @bader