[SYCL] Implements getNative() interoperability for Level Zero #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
requested review from
kbobrovs,
pvchupin,
smaslov-intel and
a team
as code owners
|
Changes in this PR are on top of #1718. |
s-kanaev
reviewed
May 27, 2020
keryell
reviewed
Jun 10, 2020
bader
pushed a commit
that referenced
this pull request
Jun 17, 2020
…ion (#1846) The implementation is following https://github.com/KhronosGroup/SYCL-Shared/blob/master/proposals/sycl_generalization.md. It is OpenCL centric, and a Level-Zero counterpart is coming here: #1723 An important "side-effect" is that plugins are initialized from these APIs and not only from get_platforms() in the current state. Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
|
Sorry for the force push. I just rebased without any changes to the patch, otherwise there are too many commits which were already merged and cause confusion. |
* New backend which implements interoperability for Level Zero. L0 interop handler getters and "make" functions for the following objects are implemented: platform, device, queue, program, accessor. * getNative() interoperability for the platform and program. Changes to ABI are non-breaking (new symbols are exported). Changed version of the sycl library accordingly. Author: Sergey V Maslov <sergey.v.maslov@intel.com> Signed-off-by: Artur Gainullin <artur.gainullin@intel.com>
|
@keryell Sorry, marked your comments as resolved because they are regarding the plugin which is not a part of this PR. |
|
@s-kanaev Could you please review. |
s-kanaev
reviewed
Jun 30, 2020
|
|
||
| #pragma once | ||
|
|
||
| //#include <ze_api.h> This should be included from user code |
There was a problem hiding this comment.
This should be aligned with CL/sycl/backend/opencl.hpp. It includes (though, indirectly) the CL/cl.h file.
s-kanaev
previously approved these changes
Jul 1, 2020
smaslov-intel
approved these changes
Jul 2, 2020
KornevNikita
pushed a commit
to KornevNikita/llvm
that referenced
this pull request
Feb 2, 2023
…ecorations (intel#1723) It was found that the decorated variables (results of ptr.annotation intrinsic) are not used in further instructions unlike the input source. The issue is present for the reverse translation of multiple UserSemantic decorations. This change fixes the reverse translation of multiple ptr.annotation intrinsics on the same class field. With this, the result of intrinsic is not lost and actually reused in further intrinsics and instructions. Original commit: KhronosGroup/SPIRV-LLVM-Translator@308daff
KornevNikita
pushed a commit
to KornevNikita/llvm
that referenced
this pull request
Feb 20, 2023
…ecorations (intel#1723) It was found that the decorated variables (results of ptr.annotation intrinsic) are not used in further instructions unlike the input source. The issue is present for the reverse translation of multiple UserSemantic decorations. This change fixes the reverse translation of multiple ptr.annotation intrinsics on the same class field. With this, the result of intrinsic is not lost and actually reused in further intrinsics and instructions. Original commit: KhronosGroup/SPIRV-LLVM-Translator@308daff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit includes:
Changes to ABI are non-breaking (new symbols are exported). Changed version of the sycl library accordingly.
Author: Sergey V Maslov sergey.v.maslov@intel.com
Signed-off-by: Artur Gainullin artur.gainullin@intel.com