[SYCL] Untie PI functions from OpenCL #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce pi_buffer_region type and use it instead of cl_buffer_region * Introduce pi_fp_capabilities enum and use it in PI functions * Fix type of mem advice parameter in piextUSMEnqueueMemAdvise * Use pi_event_info instead of cl_event_info * Extend pi_device_info with subgroup properties * Extend pi_device_info with enum values to query subgroup information and IL version, this values are going to be used level zero plugin Signed-off-by: Artur Gainullin <artur.gainullin@intel.com>
againull
force-pushed
the
untie_from_opencl
branch
from
bc4f5c3 to
249e57b
Compare
|
@againull , please do not force-push as it kills the ability to do incremental review |
smaslov-intel
previously approved these changes
May 19, 2020
Signed-off-by: Artur Gainullin <artur.gainullin@intel.com>
| @@ -699,7 +699,7 @@ struct pi_buffer_region_struct { | |||
| size_t origin; | |||
| size_t size; | |||
| }; | |||
| using pi_buffer_region_struct *pi_buffer_region; | |||
| using pi_buffer_region = pi_buffer_region_struct *; | |||
There was a problem hiding this comment.
BTW, all of pi.h is meant to be C-only interface
smaslov-intel
approved these changes
May 19, 2020
sergey-semenov
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and IL version, this values are going to be used level zero plugin
Signed-off-by: Artur Gainullin artur.gainullin@intel.com