-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Release notes for May'20 DPCPP implementation update #1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sycl/ReleaseNotes.md
Outdated
version below 16.3.0 | ||
The workaround is to enable `-std=c++17` for the failing MSVC version. | ||
|
||
## Prerequisites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should point to exact revision of https://github.com/intel/llvm/blob/sycl/buildbot/dependency.conf used for testing 67d3d9e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should probably just remove prerequisites from release notes, but we need GetStartedGuide.md update first.
Basically idea is that dependency.conf for corresponding tag or any commit should always point to the recommended dependencies for this commit.
I also don't want to block May'20 release notes by this cleanup needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1699 is in progress, so let's remove prerequisites from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
sycl/ReleaseNotes.md
Outdated
version below 16.3.0 | ||
The workaround is to enable `-std=c++17` for the failing MSVC version. | ||
|
||
Please, see the runtime installation guide [here](https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md#install-low-level-runtime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this line as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Added new known issue while the patch is still on review. |
No description provided.