Skip to content

[SYCL][Doc] Update C++ standard library support status #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,8 @@ classes by purpose(e.g. <math.h> for mathematical operations and
transformations) and device library infrastructure uses this as
a baseline.
NOTE: Only the GNU glibc, Microsoft C libraries are currently
supported. The device libraries for <math.h> and <complex.h> are
ready for Linux and Windows support will be added in the future.
Not all functions from <math.h> are supported right now, following
math functions are not supported now:
supported. Not all functions from <math.h> are supported right now,
following math functions are not supported now:
- abs
- ceilf, ceil
- copysignf, copysign
Expand All @@ -114,6 +112,9 @@ math functions are not supported now:
- nanf, nan
Device libraries can't support both single and double precision as some
underlying device may not support double precision.
'ldexpf' and 'frexpf' from MSVC <math.h> are implemented using corresponding
double precision version, they can be used only when double precision is
supported by underlying device.

Example of usage
================
Expand Down
3 changes: 0 additions & 3 deletions sycl/source/detail/program_manager/program_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -672,9 +672,6 @@ RTDeviceBinaryImage &ProgramManager::getDeviceImage(OSModuleHandle M,
return *Img;
}

// TODO: getDeviceLibPrograms should also support Windows but
// current implementation doesn't work on Windows when multiple
// device libraries exist and this problem should be fixed.
static std::vector<RT::PiProgram>
getDeviceLibPrograms(const ContextImplPtr Context,
const std::vector<RT::PiDevice> &Devices,
Expand Down