[SYCL][E2E] Add CUDA SDK autodetection #16896
Conversation
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
sarnex
changed the title
| find_package(CUDAToolkit) | ||
|
|
||
| if(CUDAToolkit_FOUND) | ||
| set(CUDA_LIBS_DIR "${CUDAToolkit_LIBRARY_DIR}") |
There was a problem hiding this comment.
what overrides what if both this and explicit params are present?
There was a problem hiding this comment.
Typically, explicit command line arguments override defaults.
What error do we get if CMake can't find CUDA toolkit and user hasn't set the paths via cmd options? Does it make sense to add diagnostics to CMake files or LIT infrastructure already provides good diagnostics?
There was a problem hiding this comment.
previously and still with this pr we get no error, we just dont enable the cuda_dev_kit feature.
the command line lit params will override the default
There was a problem hiding this comment.
Doesn't this code override CMake CUDA_INCLUDE/CUDA_LIBS_DIR variables passed via command line?
There was a problem hiding this comment.
ah i didnt consider anyone using cmake command line, ill fix it to not do the autodetection if theyre set
Follow-up from #16896 Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
3 participants
Add autodetection of the CUDA SDK using CMake's builtin
find_package.I didn't remove the LIT params or handling in lit.py as to not break anyone who may want to use a custom install.
Confirmed working here as
Adapters/cuda_queue_priority.cpppassed.