Skip to content

[SYCL][DOC] Describe process of prototyping KHR extensions #16883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexeySachkov
Copy link
Contributor

No description provided.

@AlexeySachkov AlexeySachkov marked this pull request as ready for review February 6, 2025 12:00
@AlexeySachkov AlexeySachkov requested a review from a team as a code owner February 6, 2025 12:00
@AlexeySachkov AlexeySachkov requested a review from a team February 6, 2025 12:01
Copy link
Contributor

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Please ping me once this is merged, and I'll make sure to add the macro to the few KHR POCs I'm trying to merge in.

Note: merge of an extension proposal PR into KhronosGroup/SYCL-Docs repo is
**not** considered to be a publishing event. The extension specification has
to be available on the Khronos SYCL Registry website:
https://registry.khronos.org/SYCL/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this part. For changes to the SYCL specification, we usually consider a change to be "accepted" by the Khronos WG when the PR is merged to the SYCL-Docs repo. Why not follow the same strategy for KHRs?

More precisely, I think we should wait for the KHR to be merged / cherry-picked to the "sycl-2020" branch of SYCL-Docs. We don't do this until the KHR has been approved by the WG and also ratified by the Khronos board.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this part. For changes to the SYCL specification, we usually consider a change to be "accepted" by the Khronos WG when the PR is merged to the SYCL-Docs repo. Why not follow the same strategy for KHRs?

I guess my point was also to wait until the documentation is publicly available to end users in some friendly form. But I agree that this is not a critical thing so I'm fine with different wording here.

More precisely, I think we should wait for the KHR to be merged / cherry-picked to the "sycl-2020" branch of SYCL-Docs. We don't do this until the KHR has been approved by the WG and also ratified by the Khronos board.

Sure, I can apply that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded that bullet in 0588f7f

@steffenlarsen steffenlarsen merged commit d160d75 into intel:sycl Feb 10, 2025
3 checks passed
@AlexeySachkov AlexeySachkov deleted the private/asachkov/dev-process-for-khr-extensions branch February 10, 2025 13:41
Pennycook added a commit to Pennycook/llvm that referenced this pull request Feb 10, 2025
Functionality guarded by __DPCPP_ENABLE_UNFINISHED_KHR_EXTENSIONS,
following the process introduced by intel#16883.

Signed-off-by: John Pennycook <john.pennycook@intel.com>
@aelovikov-intel
Copy link
Contributor

Doesn't that apply to the changes to the SYCL specification itself? Should we extend that document to it as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants