[SYCL] Add SYCL registered kernel metadata into property sets #16821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM from the SYCL-RTC side, thanks! |
|
We also need at least an E2E test. It might be added in a follow up PR, but we need it. |
|
I observed that after device code split, the resulting modules always contain all |
|
@jopperm good point, I've updated the PR with the functionality to do this, take another look |
maarquitos14
approved these changes
Feb 10, 2025
jopperm
approved these changes
Feb 12, 2025
llvm/test/tools/sycl-post-link/sycl-registered-kernels-empty.ll
Outdated
Show resolved
Hide resolved
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@jzc @steffenlarsen E2E failures seem unrelated and anecdotally (#17032) go away after merging with tip -- can you update the PR and land it, please? |
uditagarwal97
pushed a commit
that referenced
this pull request
Feb 27, 2025
This PR adds full support for the `registered_kernel_names` property to query kernels by their souce code name (and instantiate template kernels), leveraging the new `[[__sycl_detail__::__registered_kernels__(...)]]` attribute added in #16485 and #16821. Also, `kernel_bundle::ext_oneapi_get_raw_kernel_name` is implemented following the draft spec #11985. --------- Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the sycl kernel compiler extension, see #11985, #16485