[SYCL][DOC] Add table with DPC++ extensions status #1619

romanovvlad · 2020-04-30T13:54:18Z

Signed-off-by: Vlad Romanov vlad.romanov@intel.com

Signed-off-by: Vlad Romanov <vlad.romanov@intel.com>

romanovvlad · 2020-04-30T13:59:01Z

It would be nice if you review the status of the extensions in this table and suggest a comment about what specifically is already supported for the "partially supported" extensions.

Pennycook · 2020-04-30T14:12:14Z

sycl/doc/extensions/README.md

+| [SYCL_INTEL_device_specific_kernel_queries](DeviceSpecificKernelQueries/SYCL_INTEL_device_specific_kernel_queries.asciidoc) | Proposal | |
+| [SYCL_INTEL_enqueue_barrier](EnqueueBarrier/enqueue_barrier.asciidoc) | Proposal | |
+| [SYCL_INTEL_extended_atomics](ExtendedAtomics/SYCL_INTEL_extended_atomics.asciidoc) | Proposal | |
+| [SYCL_INTEL_group_algorithms](GroupAlgorithms/SYCL_INTEL_group_algorithms.asciidoc) | Proposal | |


Pennycook · 2020-04-30T14:14:13Z

sycl/doc/extensions/README.md

+| [SPV_INTEL_function_pointers](SPIRV/SPV_INTEL_function_pointers.asciidoc) | Supported | |
+| [SPV_INTEL_inline_assembly](SPIRV/SPV_INTEL_inline_assembly.asciidoc) | Supported | |
+| [SYCL_INTEL_static_local_memory_query](StaticLocalMemoryQuery/SYCL_INTEL_static_local_memory_query.asciidoc) | Proposal | |
+| [SYCL_INTEL_sub_group_algorithms](SubGroupAlgorithms/SYCL_INTEL_sub_group_algorithms.asciidoc) | Proposal | |


Suggested change

| [SYCL_INTEL_sub_group_algorithms](SubGroupAlgorithms/SYCL_INTEL_sub_group_algorithms.asciidoc) | Proposal | |

| [SYCL_INTEL_sub_group_algorithms](SubGroupAlgorithms/SYCL_INTEL_sub_group_algorithms.asciidoc) | Partially supported | Features from SYCL_INTEL_group_algorithms extended to sub-groups. Does not support host device. |

Pennycook · 2020-04-30T14:15:48Z

sycl/doc/extensions/README.md

+| [SPV_INTEL_inline_assembly](SPIRV/SPV_INTEL_inline_assembly.asciidoc) | Supported | |
+| [SYCL_INTEL_static_local_memory_query](StaticLocalMemoryQuery/SYCL_INTEL_static_local_memory_query.asciidoc) | Proposal | |
+| [SYCL_INTEL_sub_group_algorithms](SubGroupAlgorithms/SYCL_INTEL_sub_group_algorithms.asciidoc) | Proposal | |
+| [Sub-groups for NDRange Parallelism](SubGroupNDRange/SubGroupNDRange.md) | Proposal | |


@Pennycook , @romanovvlad , do we need to add "SubGroups" to the list? https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/SubGroup/SYCL_INTEL_sub_group.asciidoc

It's already mentioned, see line 31

I think it's not. There are 3 extensions in the directory: Subgroup, SubGroupNDRange and SubgroupAlgorithms and I think we want status per each.

@pvchupin is right. I suggested what the Subgroup extension line could look like here: #1619 (comment)

SubGroupNDRange includes some queries and functions that were deprecated when equivalent functionality was introduced in GroupAlgorithms and SubgroupAlgorithms. We'll eventually drop support for it entirely (and when that happens we can probably remove its row from this table).

Applied original comment and added the line John suggested.

Pennycook · 2020-04-30T14:17:10Z

We should add a line:

| [Sub-groups](SubGroup/SYCL_INTEL_sub_group.asciidoc) | Partially supported | Does not support host device. |

bader · 2020-04-30T16:17:27Z

sycl/doc/extensions/README.md

+The directory contains documents that describe DPC++ extensions to SYCL
+specification.
+
+DPC++ extensions status:


Could we add a legend with possible "Status" values?

I have a selfish interest to capture information about the compiler options to turn on/off these extensions.
Do you think we can add another column?

A column with compiler options which turn on/off specific extensions?
What do you think about having them in https://github.com/intel/llvm/blob/sycl/sycl/doc/UsersManual.md
and add a link from this doc to the user manual?

Sounds good to me.

AFAIK, some extensions are "library-only" and there is no dedicated clang driver option to manage library extensions - they are managed through macro definitions.

they are managed through macro definitions.

Can we have such macro documented in the user manual as well?

I think we should document them and align extensions API with this proposal: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/ExtensionMechanism/SYCL_INTEL_extension_api.asciidoc.

Added a link to user manual, please, let me know if something else should be done in scope of this comment.

sycl/doc/extensions/README.md

bader · 2020-05-01T18:07:45Z

sycl/doc/extensions/README.md

+specification.
+
+DPC++ extensions status:
+


printf extension seems to be missing.

These others seem to be missing too:

Specialization constants

Generic interoperability between DPC++ and native RT (https://github.com/KhronosGroup/SYCL-Shared/blob/master/proposals/sycl_generalization.md)

@bader , do we have an extension doc for the printf extension?
@smaslov-intel I haven't added non-Intel extensions intentionally.
@pvchupin Should we track non-Intel extensions here? What if they are not implemented so far?

@bader , do we have an extension doc for the printf extension?

I've requested it here, but there were updates yet. @AlexeySachkov any updates?

@pvchupin Should we track non-Intel extensions here? What if they are not implemented so far?

I think this table purpose is to clarify what we support or planning to prototype in the nearest future (Intel or non-Intel doesn't matter).
In particular we have specialization constants implementation, so we should add it. We should probably add generalization too. I don't think we should extend this list to all existing drafts, only to those we are considering or prototyped already.

Ok, are you OK if these extensions are added to the table in a separate PR(preferably by the authors)?

sycl/doc/extensions/README.md

Ruyk · 2020-05-04T08:53:16Z

I think when mentioned "Supported" , it should be listed which backend supports the extension. The CUDA backend doesn't support many of them.

pvchupin · 2020-05-04T21:51:04Z

I think when mentioned "Supported" , it should be listed which backend supports the extension. The CUDA backend doesn't support many of them.

Good point. @romanovvlad we may need another column.

smaslov-intel · 2020-05-01T23:53:52Z

sycl/doc/extensions/README.md

+specification.
+
+DPC++ extensions status:
+


These others seem to be missing too:

Specialization constants

Generic interoperability between DPC++ and native RT (https://github.com/KhronosGroup/SYCL-Shared/blob/master/proposals/sycl_generalization.md)

smaslov-intel · 2020-05-01T23:59:42Z

sycl/doc/extensions/README.md

+The directory contains documents that describe DPC++ extensions to SYCL
+specification.
+
+DPC++ extensions status:


Could we please maintain more info about the extensions and capture this:

where it is targeted, i.e. which devices/backends are going to support it

current availability through various targeted backends

what SW components are known to be involved in the implementation (e.g. SYCL headers, SPIR-V, SYCL RT, PI,...)

I think that if we add all this information the table will be too complex, but I can add a couple of columns that can be filled in future.

smaslov-intel · 2020-05-04T21:54:34Z

I think when mentioned "Supported" , it should be listed which backend supports the extension. The CUDA backend doesn't support many of them.

Good point. @romanovvlad we may need another column.

smaslov-intel · 2020-05-04T21:55:28Z

I think when mentioned "Supported" , it should be listed which backend supports the extension. The CUDA backend doesn't support many of them.

Good point. @romanovvlad we may need another column.

Please consider documenting even more:

where it is targeted, i.e. which devices/backends are going to support it
current availability through various targeted backends
what SW components are known to be involved in the implementation (e.g. SYCL headers, SPIR-V, SYCL RT, PI,...)

romanovvlad · 2020-05-12T10:48:34Z

I think when mentioned "Supported" , it should be listed which backend supports the extension. The CUDA backend doesn't support many of them.

Good point. @romanovvlad we may need another column.

What is a separate column for?
I suggest change the format of the Status column to something like this:
Supported(OpenCL), Partially supported(CUDA)

sycl/doc/extensions/README.md

pvchupin · 2020-05-12T22:00:43Z

What is a separate column for?
I suggest change the format of the Status column to something like this:
Supported(OpenCL), Partially supported(CUDA)

That's fine to me.

sycl/doc/extensions/README.md

bader · 2020-05-17T09:42:49Z

@romanovvlad, is it still a draft PR or ready for review?

romanovvlad · 2020-05-19T17:11:10Z

@romanovvlad, is it still a draft PR or ready for review?

Yes, I believe I resolved all the comments I could.

sycl/doc/extensions/README.md

romanovvlad · 2020-05-21T13:41:19Z

@smaslov-intel ping

bader · 2020-05-26T09:41:41Z

@romanovvlad, please, resolve conflicts.

romanovvlad · 2020-05-26T10:25:00Z

@romanovvlad, please, resolve conflicts.

Done.

Original commit: KhronosGroup/SPIRV-LLVM-Translator@24f81e3

[SYCL][DOC] Added table with DPC++ extensions status

a3c149e

Signed-off-by: Vlad Romanov <vlad.romanov@intel.com>

romanovvlad requested review from Pennycook, jbrodman, asavonic, AlexeySachkov, Fznamznon, kbobrovs, mkinsner, v-klochkov, pvchupin and GarveyJoe April 30, 2020 13:54

Pennycook reviewed Apr 30, 2020

View reviewed changes

bader reviewed Apr 30, 2020

View reviewed changes

v-klochkov reviewed Apr 30, 2020

View reviewed changes

sycl/doc/extensions/README.md Outdated Show resolved Hide resolved

bader added the spec extension All issues/PRs related to extensions specifications label May 1, 2020

bader reviewed May 1, 2020

View reviewed changes

MrSidims reviewed May 2, 2020

View reviewed changes

sycl/doc/extensions/README.md Outdated Show resolved Hide resolved

smaslov-intel suggested changes May 4, 2020

View reviewed changes

smaslov-intel closed this May 4, 2020

smaslov-intel reopened this May 4, 2020

jbrodman previously approved these changes May 7, 2020

View reviewed changes

romanovvlad dismissed jbrodman’s stale review via 934ba64 May 12, 2020 13:48

romanovvlad commented May 12, 2020

View reviewed changes

sycl/doc/extensions/README.md Outdated Show resolved Hide resolved

sycl/doc/extensions/README.md Outdated Show resolved Hide resolved

sycl/doc/extensions/README.md Outdated Show resolved Hide resolved

romanovvlad marked this pull request as draft May 12, 2020 17:16

romanovvlad requested review from bader, Pennycook, smaslov-intel, jbrodman, MrSidims and v-klochkov May 14, 2020 12:28

Pennycook reviewed May 14, 2020

View reviewed changes

sycl/doc/extensions/README.md Outdated Show resolved Hide resolved

applying comments

77e41b9

romanovvlad force-pushed the private/vromanov/ExtensionsStatus branch from 2659355 to 77e41b9 Compare May 18, 2020 17:58

romanovvlad marked this pull request as ready for review May 18, 2020 17:58

applying comments

ea0d072

v-klochkov reviewed May 19, 2020

View reviewed changes

sycl/doc/extensions/README.md Outdated Show resolved Hide resolved

applying comments

f390659

romanovvlad requested review from v-klochkov and Pennycook May 21, 2020 13:40

smaslov-intel approved these changes May 21, 2020

View reviewed changes

v-klochkov approved these changes May 21, 2020

View reviewed changes

conflict resolution

ad84252

bader merged commit dbbc474 into intel:sycl May 26, 2020

dbudanov-cmplr pushed a commit to dbudanov-cmplr/llvm that referenced this pull request Sep 19, 2022

Migrate more miscellaneous calls to the mutator interface. (intel#1619)

cadee86

Original commit: KhronosGroup/SPIRV-LLVM-Translator@24f81e3

dbudanov-cmplr pushed a commit to dbudanov-cmplr/llvm that referenced this pull request Sep 28, 2022

Migrate more miscellaneous calls to the mutator interface. (intel#1619)

5bb4298

Original commit: KhronosGroup/SPIRV-LLVM-Translator@24f81e3

	\| [SYCL_INTEL_group_algorithms](GroupAlgorithms/SYCL_INTEL_group_algorithms.asciidoc) \| Proposal \| \|
	\| [SYCL_INTEL_group_algorithms](GroupAlgorithms/SYCL_INTEL_group_algorithms.asciidoc) \| Partially supported \| Does not support host device \|

	\| [SYCL_INTEL_sub_group_algorithms](SubGroupAlgorithms/SYCL_INTEL_sub_group_algorithms.asciidoc) \| Proposal \| \|
	\| [SYCL_INTEL_sub_group_algorithms](SubGroupAlgorithms/SYCL_INTEL_sub_group_algorithms.asciidoc) \| Partially supported \| Features from SYCL_INTEL_group_algorithms extended to sub-groups. Does not support host device. \|

	\| [Sub-groups for NDRange Parallelism](SubGroupNDRange/SubGroupNDRange.md) \| Proposal \| \|
	\| [Sub-groups for NDRange Parallelism](SubGroupNDRange/SubGroupNDRange.md) \| Deprecated \| Does not support host device. \|

[SYCL][DOC] Add table with DPC++ extensions status #1619

[SYCL][DOC] Add table with DPC++ extensions status #1619

Conversation

romanovvlad commented Apr 30, 2020

romanovvlad commented Apr 30, 2020

Choose a reason for hiding this comment

romanovvlad May 19, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pennycook commented Apr 30, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pvchupin May 21, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ruyk commented May 4, 2020

pvchupin commented May 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smaslov-intel commented May 4, 2020

smaslov-intel commented May 4, 2020

romanovvlad commented May 12, 2020

pvchupin commented May 12, 2020

bader commented May 17, 2020

romanovvlad commented May 19, 2020

romanovvlad commented May 21, 2020

bader commented May 26, 2020

romanovvlad commented May 26, 2020

romanovvlad May 19, 2020 •

edited

Loading

pvchupin May 21, 2020 •

edited

Loading