Skip to content

[SYCL] Fix segmentation fault that occurs when creating host accessors in parallel #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2020
Merged

[SYCL] Fix segmentation fault that occurs when creating host accessors in parallel #1597

merged 4 commits into from
Apr 29, 2020

Conversation

dm-vodopyanov
Copy link
Contributor

Signed-off-by: Dmitry Vodopyanov dmitry.vodopyanov@intel.com

…s in parallel

Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner April 28, 2020 12:38
Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
Copy link
Contributor

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear why it happens.
Is it because you are looking to late and release too early?
I do not remember this issue in triSYCL, even if there are currently some other problems.

Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
@dm-vodopyanov
Copy link
Contributor Author

@keryell correct, this is typical data race caused by accessing data by one thread which was already released by another thread. Segmentation fault was happened on line 508 of Command::enqueue(...) func:

  cl_int Res = enqueueImp();

Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants