Merged
Conversation
Closed
alexbatashev
previously approved these changes
Apr 22, 2020
Contributor
alexbatashev
left a comment
alexbatashev
left a comment
There was a problem hiding this comment.
I wonder, if we can use this opportunity to align test code style with the rest of project. Otherwise, LGTM.
Move LIT test code for buffers that uses OpenCL C online compilation to related interop test. Signed-off-by: Bjoern Knafla <bjoern@codeplay.com>
bjoernknafla
force-pushed
the
bjoern/move-lit-buffer-interop-code
branch
from
eddf08b to
85b9b75
Compare
Author
|
Also applied clang-format-9 to |
bader
approved these changes
Apr 23, 2020
Contributor
bader
left a comment
bader
left a comment
There was a problem hiding this comment.
Thanks a lot for working on this.
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 29, 2020
…versioning * origin/sycl: [XPTI][Framework] Reference implementation of the Xpti framework to be used with instrumentation in SYCL (intel#1557) [SYCL] Initial ABI checks implementation (intel#1528) [SYCL] Support connection with multiple plugins (intel#1490) [SYCL] Add a new header file with the reduction class definition (intel#1558) [SYCL] Add test for SYCL kernels with accessor and spec constant (intel#1536) [SYCL][CUDA] Move interop tests (intel#1570) [Driver][SYCL] Remove COFF object format designator for Windows device compiles (intel#1574) [SYCL] Fix conflicting visibility attributes (intel#1571) [SYCL][DOC] Update the SYCL Runtime Interface document with design details (intel#680) [SYCL] Improve image accessors support on a host device (intel#1502) [SYCL] Make queue's non-USM event ownership temporary (intel#1561) [SYCL] Added support of rounding modes for non-host devices (intel#1463) [SYCL] SemaSYCL significant refactoring (intel#1517) [SYCL] Support 0-dim accessor in handler::copy(accessor, accessor) (intel#1551)
bb-sycl
pushed a commit
that referenced
this pull request
Sep 15, 2022
…re enabled. (#1570) The frontend is being changed to lower the struct name to the correct LLVM name directly, obviating the need for this check. See #6535 for this change. This marks the removal of the final call to the deprecated method Type::getPointerElementType, although there remains some code that is not fully working with opaque pointers enabled. Original commit: KhronosGroup/SPIRV-LLVM-Translator@e2bb479
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move LIT test code for buffers that uses OpenCL C online compilation to
related interop test.
Apply clang-format.
Signed-off-by: Bjoern Knafla bjoern@codeplay.com