Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Fix device lib req mask for spirv target #15336

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Sep 9, 2024

Triple check was wrong.

Found this working on thinLTO.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex
Copy link
Contributor Author

sarnex commented Sep 9, 2024

Windows build fail not related

@sarnex sarnex marked this pull request as ready for review September 9, 2024 21:13
@sarnex sarnex requested a review from a team as a code owner September 9, 2024 21:13
@sarnex
Copy link
Contributor Author

sarnex commented Sep 11, 2024

@intel/dpcpp-tools-reviewers Ping, thanks :)

Copy link
Contributor

@maksimsab maksimsab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarnex sarnex merged commit 47c0180 into intel:sycl Sep 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants