-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][Doc] Add reduction properties extension #15213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines new compile-time properties that provide developers with greater control over how a reduction may be implemented. Signed-off-by: John Pennycook <john.pennycook@intel.com>
gmlueck
reviewed
Aug 29, 2024
sycl/doc/extensions/proposed/sycl_ext_oneapi_reduction_properties.asciidoc
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_reduction_properties.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_reduction_properties.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Drop reference to "value representation" because it was confusing. Signed-off-by: John Pennycook <john.pennycook@intel.com>
gmlueck
reviewed
Aug 30, 2024
sycl/doc/extensions/proposed/sycl_ext_oneapi_reduction_properties.asciidoc
Outdated
Show resolved
Hide resolved
853b4bd
to
df0aa9b
Compare
Signed-off-by: John Pennycook <john.pennycook@intel.com>
df0aa9b
to
a33abc4
Compare
It must be the same work-item that contributes the same values. Signed-off-by: John Pennycook <john.pennycook@intel.com>
gmlueck
approved these changes
Aug 30, 2024
@intel/llvm-gatekeepers, this can be merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines new compile-time properties that provide developers with greater control over how a reduction may be implemented.
Closes #1621 .