[CI] Move shared library testing to nightly #14996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
commented
Aug 13, 2024
| run: | | ||
| PREINSTALLED_CLANG_PATH=`which clang` | ||
| PREINSTALLED_INSTALL_DIR=`echo $PREINSTALLED_CLANG_PATH | rev | cut -c7- | rev` | ||
| cp "${PREINSTALLED_INSTALL_DIR}/lld" $GITHUB_WORKSPACE/build/install/bin/ |
There was a problem hiding this comment.
This is not exactly pretty, but I don't have any better ideas because:
- The
lldavailable by default in the Ubuntu image we use wasn't built withamdgputarget support - The
lldavailable in the development PPAs provided by LLVM wasn't built withamdgputarget support
Basically we are just copying over the lld from the build image, which is a static library build.
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
sarnex
changed the title
|
Arc failure not related, fixed in HEAD. Nightly run passed here |
|
@aelovikov-intel Your feedback should be addressed and this seems fine to do based on the email thread response IMO. |
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
aelovikov-intel
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only value for shared library build is making sure the build isn't broken for developers. Using sharedlib build in postcommit complicates HIP testing.
Move precommit to use static lib build and move shared library build+lit to nightly only.