[SYCL] Default-initialize UR structs used in handler_impl #14885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProGTX
approved these changes
Aug 1, 2024
uditagarwal97
approved these changes
Aug 1, 2024
cppchedy
approved these changes
Aug 2, 2024
|
@intel/llvm-gatekeepers This should be ready for merge; The last pending CI check is for the E2E test on AWS CUDA; this test has been disabled and thus won't finish. |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
The C-style structs used by the `handler_impl` for bindless images are not initialized. Although their values get initialized later in execution, when it is decided this information is actually used, leaving these values uninitialized still leave the possibility of vulnerabilities. This PR initializes them. I'd like to bring attention to the fact that we could also use `std::optional` here, although that'll increase the size used for each field here. Zero initializing these structs is also an option, although I noticed many of these structs have default values, so I default initialized instead. If `std::optional` or zero initializing would be a better option here, please let me know and I'll make the changes. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C-style structs used by the
handler_implfor bindless images are not initialized. Although their values get initialized later in execution, when it is decided this information is actually used, leaving these values uninitialized still leave the possibility of vulnerabilities. This PR initializes them.I'd like to bring attention to the fact that we could also use
std::optionalhere, although that'll increase the size used for each field here. Zero initializing these structs is also an option, although I noticed many of these structs have default values, so I default initialized instead. Ifstd::optionalor zero initializing would be a better option here, please let me know and I'll make the changes. Thanks!