-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][ABI-Break] Hide some exported symbols #14615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][ABI-Break] Hide some exported symbols #14615
Conversation
Both `get_pi_error` and `set_pi_error` are only called from the library and therefore there is no need for them to be exported.
@@ -1,5 +1,6 @@ | |||
// for CUDA and HIP the failure happens at compile time, not during runtime | |||
// UNSUPPORTED: cuda || hip || ze_debug | |||
// TODO: rewrite this into a unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the whole intent of this PR is to minimize amount of changes in "drop PI" PR, I'm postponing this rewrite to reduce amount of conflicts.
We might not have interop implementing this, but it's theoretically possible. I wonder if that would/might result in an unresolved symbol later on. I'd feel a bit better if we moved it WDYT? |
I see that such interop API even documented by the SYCL 2020 spec in C.7.4. Errors and limitations: No objections against moving the implementation into the header, it is really small |
…-unnecessarily-exported-symbols
Applied this comment in e606769 |
Both
get_pi_error
andset_pi_error
are only called from the library and therefore there is no need for them to be exported.This patch is essentially a by-product of #14145 and it is done to simplify that change, i.e. PI plugins removal should not be ABI-breaking by itself, we just need to cleanup some of our exported symbols.