Skip to content

[SYCL][ABI-Break] Hide some exported symbols #14615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexeySachkov
Copy link
Contributor

@AlexeySachkov AlexeySachkov commented Jul 18, 2024

Both get_pi_error and set_pi_error are only called from the library and therefore there is no need for them to be exported.

This patch is essentially a by-product of #14145 and it is done to simplify that change, i.e. PI plugins removal should not be ABI-breaking by itself, we just need to cleanup some of our exported symbols.

Both `get_pi_error` and `set_pi_error` are only called from the library
and therefore there is no need for them to be exported.
@AlexeySachkov AlexeySachkov requested a review from a team as a code owner July 18, 2024 07:50
@AlexeySachkov AlexeySachkov added the abi-break change that's breaking abi and waiting for the next window to be able to merge label Jul 18, 2024
@@ -1,5 +1,6 @@
// for CUDA and HIP the failure happens at compile time, not during runtime
// UNSUPPORTED: cuda || hip || ze_debug
// TODO: rewrite this into a unit-test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the whole intent of this PR is to minimize amount of changes in "drop PI" PR, I'm postponing this rewrite to reduce amount of conflicts.

@aelovikov-intel
Copy link
Contributor

We might not have interop implementing this, but it's theoretically possible. I wonder if that would/might result in an unresolved symbol later on. I'd feel a bit better if we moved it exception.cpp->exception.hpp and made it inline.

WDYT?

@AlexeySachkov
Copy link
Contributor Author

We might not have interop implementing this, but it's theoretically possible. I wonder if that would/might result in an unresolved symbol later on. I'd feel a bit better if we moved it exception.cpp->exception.hpp and made it inline.

WDYT?

I see that such interop API even documented by the SYCL 2020 spec in C.7.4. Errors and limitations: cl_int sycl::opencl::get_error_code(sycl::exception&) so I agree that the function itself can get more uses. And who knows if the interface would be generalized so it is a templated one which is easier to implement in headers.

No objections against moving the implementation into the header, it is really small

@AlexeySachkov
Copy link
Contributor Author

We might not have interop implementing this, but it's theoretically possible. I wonder if that would/might result in an unresolved symbol later on. I'd feel a bit better if we moved it exception.cpp->exception.hpp and made it inline.

WDYT?

Applied this comment in e606769

@AlexeySachkov AlexeySachkov merged commit ce81199 into intel:sycl Jul 19, 2024
14 checks passed
@AlexeySachkov AlexeySachkov deleted the private/asachkov/hide-unnecessarily-exported-symbols branch October 9, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abi-break change that's breaking abi and waiting for the next window to be able to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants