Skip to content

[SYCL] interim kernel compiler with SYCL support #14172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cperkinsintel
Copy link
Contributor

SYCL language support on the part of the kernel_compiler is specified here: #11985

However, that specification is not presently realizable. We need more support from the FE and post link tool to get the demangled names propagated through. But it is usable before that, with constraints about using extern "C" or knowing the mangled kernel name. We have folk that want to test in the interim. I've refrained from updating the spec, and instead this interim support in our experimental extension will be snuck in until it can be completed in full - then we'll update the spec to release it properly.

@cperkinsintel cperkinsintel marked this pull request as ready for review June 26, 2024 22:31
@cperkinsintel cperkinsintel requested review from a team as code owners June 26, 2024 22:31
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The temporary FE changes look okay to me.

Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@againull againull merged commit 91d6eba into intel:sycl Jul 2, 2024
13 checks passed
@againull
Copy link
Contributor

againull commented Jul 2, 2024

@cperkinsintel There post-commit failures from this commit, could you please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants